From 60fa51de9ee161b2bf7b1db66cc3f4e29d1a518c Mon Sep 17 00:00:00 2001 From: Gavin Didrichsen Date: Thu, 20 Jun 2024 12:42:55 +0100 Subject: [PATCH] Correct rubocop warnings Signed-off-by: Gavin Didrichsen --- lib/puppet-strings/yard/code_objects/task.rb | 12 +++++------- .../yard/handlers/ruby/provider_handler.rb | 5 ++--- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/puppet-strings/yard/code_objects/task.rb b/lib/puppet-strings/yard/code_objects/task.rb index a94ff8d6b..e1f8cb320 100644 --- a/lib/puppet-strings/yard/code_objects/task.rb +++ b/lib/puppet-strings/yard/code_objects/task.rb @@ -44,14 +44,12 @@ def source end def parameters - parameters = [] - statement.parameters.each do |name, props| - parameters.push({ name: name.to_s, - tag_name: 'param', - text: props['description'] || '', - types: [props['type']] || '' }) + statement.parameters.map do |name, props| + { name: name.to_s, + tag_name: 'param', + text: props['description'] || '', + types: [props['type']] || '' } end - parameters end # Converts the code object to a hash representation. diff --git a/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb b/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb index 8f16f9919..9ce6213a7 100644 --- a/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb +++ b/lib/puppet-strings/yard/handlers/ruby/provider_handler.rb @@ -107,9 +107,8 @@ def populate_provider_data(object) parameters.each do |kvps| next unless kvps.count >= 1 - defaultfor = [] - kvps.each do |kvp| - defaultfor << [node_as_string(kvp[0]) || kvp[0].source, node_as_string(kvp[1]) || kvp[1].source] + defaultfor = kvps.map do |kvp| + [node_as_string(kvp[0]) || kvp[0].source, node_as_string(kvp[1]) || kvp[1].source] end object.add_default(defaultfor) end