(GH-1039) Acceptance tests for Linux on GHActions Workflow #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanfrancrisko
added
maintenance
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #1040 +/- ##
==========================================
- Coverage 91.27% 91.19% -0.09%
==========================================
Files 138 138
Lines 5511 5563 +52
==========================================
+ Hits 5030 5073 +43
- Misses 481 490 +9
Continue to review full report at Codecov.
|
This PR adds acceptance tests on Linux as a Github Action Workflow.
It also removes .travis.yml, disabling CI tests from executing on
TravisCI, now we have parity on Github Actions.
The following dependencies were added to the `acceptance_ci` Gem
group:
- `puppet_litmus`
- `puppetlabs_spec_helper`
Litmus is used to provision a Docker container from the official
Ruby Docker hub. Currently this is only `2.5` as more work is
required to get acceptance tests operational on `2.7`.
Bolt is used to configure the container for test execution by:
- Checking out the current repo + branch
- Performing a `bundle install`
Then, again, using Bolt, the tests are kicked off within the
container using the `acceptance:local_parallel` Rake task.
In all cases (i.e. no matter the previous steps exit codes), the
container will be torn down using the `litmus:tear_down` Rake task.
The test matrix can be extended by adding more options to the
`include` param. E.g.
```
include:
- provider: docker
ruby_version: 2.7
image: ruby:2.7
```
The `provider` parameter is any of the supported provisioners
available to Litmus from the [provision](https://github.com/puppetlabs/provision)
repo of Bolt tasks.
The `image` parameter is specific to the `provider` specified. For
the Docker provisioner, this is the usual `name:[:tag|@digest]`
format.
* Add "BSD" as standard permissive license * Add "2-clause BSDL" as standard permissive license * dig up original source for log4r 1.1.10 on github which has LGPLv3 attached
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds acceptance tests on Linux as a Github Action Workflow.
It also removes .travis.yml, disabling CI tests from executing on
TravisCI, now we have parity on Github Actions.
The following dependencies were added to the
acceptance_ciGemgroup:
puppet_litmuspuppetlabs_spec_helperLitmus is used to provision a Docker container from the official
Ruby Docker hub. Currently this is only
2.5as more work isrequired to get acceptance tests operational on
2.7.Bolt is used to configure the container for test execution by:
bundle installThen, again, using Bolt, the tests are kicked off within the
container using the
acceptance:local_parallelRake task.In all cases (i.e. no matter the previous steps exit codes), the
container will be torn down using the
litmus:tear_downRake task.The test matrix can be extended by adding more options to the
includeparam. E.g.The
providerparameter is any of the supported provisionersavailable to Litmus from the provision
repo of Bolt tasks.
The
imageparameter is specific to theproviderspecified. Forthe Docker provisioner, this is the usual
name:[:tag|@digest]format.
TODO
license_finderflaggingpuppet_litmusCloses: #1039