Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance tests on Linux using Github Actions Workflow #1039

Closed
2 tasks done
sanfrancrisko opened this issue Mar 25, 2021 · 1 comment · Fixed by #1040
Closed
2 tasks done

Acceptance tests on Linux using Github Actions Workflow #1039

sanfrancrisko opened this issue Mar 25, 2021 · 1 comment · Fixed by #1040
Assignees
@sanfrancrisko
Labels
ci maintenance Internal maintenance work that shouldn't appear in the changelog

Comments

@sanfrancrisko
Copy link
Contributor

sanfrancrisko commented Mar 25, 2021 •
edited
Loading

Feature Description

In the continuing effort (see #GH-958) to remove the dependencies on Travis and AppVeyor, we should have acceptance tests running on Github Actions.

For Linux, a self hosted runner that spins up a Docker container that either is preconfigured or configured with the same Ruby versions of the supported Puppet Agents the PDK ships with. This is currently:

  • 2.5

Acceptance Criteria

  • Executes the acceptance:local_parallel Rake task
  • Will execute against Ruby 2.5 on the ruby:2.5 Docker container

Originally posted by @sanfrancrisko in #1035
@sanfrancrisko sanfrancrisko added ci maintenance Internal maintenance work that shouldn't appear in the changelog labels Mar 25, 2021
@sanfrancrisko sanfrancrisko self-assigned this Mar 25, 2021
@sanfrancrisko sanfrancrisko linked a pull request Mar 26, 2021 that will close this issue
(GH-1039) Acceptance tests for Linux on GHActions Workflow #1040
Merged
1 task
@sanfrancrisko
Copy link
Contributor Author

Dropping Ruby 2.7 as part of the acceptance criteria and raising as a separate issue - more work than anticipated.

@sanfrancrisko sanfrancrisko mentioned this issue Apr 7, 2021
Merged
1 task
jpogran added a commit that referenced this issue Apr 7, 2021
@jpogran
Merge pull request #1040 from sanfrancrisko/GH-1039/main/ghactions_li…
b632be6 
…nux_accept_tests

(GH-1039) Acceptance tests for Linux on GHActions Workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanfrancrisko sanfrancrisko

Labels
ci maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-1039) Acceptance tests for Linux on GHActions Workflow
1 participant
@sanfrancrisko