Acceptance tests on Windows using Github Actions Workflow

[sanfrancrisko]

In the continuing effort (see #GH-958) to remove the dependencies on Travis and AppVeyor, we should have acceptance tests running on Github Actions.

For Windows, the IAC Team's provision service can be used to spin up a Windows Server 2019 and 2016 host with the following Ruby versions:

• 2.5
• 2.7

Acceptance Criteria

• Provisions a windows-2019 runner on Github

• Sets up Ruby 2.5 on this Windows Server 2019 host

• Executes the acceptance:local_parallel Rake task

• Will execute against Ruby 2.5 on this Windows 2019 host

• Provisions a windows-2016 runner on Github

• Sets up Ruby 2.5 on a Windows Server 2016 host

• Executes the acceptance:local_parallel Rake task

• Will execute against Ruby 2.5 on a Windows 2016 host

• Provisions a windows-2019 runner on Github

• Sets up Ruby 2.7 on this Windows Server 2019 host

• Executes the acceptance:local_parallel Rake task

• Will execute against Ruby 2.7 on this Windows 2019 host

• Provisions a windows-2016 runner on Github

• Sets up Ruby 2.7 on a Windows Server 2016 host

• Executes the acceptance:local_parallel Rake task

• Will execute against Ruby 2.7 on a Windows 2016 host

[sanfrancrisko]

A few points of conversation:

Windows Version Support

We execute on both Windows Server 2016 and 2019 on AppVeyor. Server 2016 can be added in as a platform to the acceptance criteria.

Ruby Versions

We will only support Ruby 2.5 initially to keep parity with our current coverage. Ruby 2.7 support will be added later.

Acceptance Rake Task

The acceptance:local_parallel Rake task seems to encompass the test coverage we're interested in and therefore is the only one required:

• acceptance:local: excludes tests with package tag
• acceptance:smoke: excludes tests with package tag; only runs spec/acceptance/bundle_spec.rb

[sanfrancrisko]

A non-interactive ruby installation could be installed on Puppet's internal ABS VM provisioning service hosts:

Install-PackageProvider -Name NuGet -MinimumVersion 2.8.5.201 -Force
Install-Module -Name RubyInstaller -Force
Install-Ruby '2.5.8-2 (x64)'

This has also been tested against a Windows Server 2019 Google Cloud instance too, albeit locally. There were some issues with WinRM communication remotely, which I'm sure can be resolved.

There are some errors, post installation, from pacman that need to be looked in to, however, Ruby does install to C:\tools:

: To complete this update all MSYS2 processes including this terminal will be closed. Confirm to proceed [Y/n]
MSYS2 system update (optional) succeeded
Kill all running msys2 binaries to avoid error "size of shared memory region changed"
MSYS2 system update (optional) part 2 ...
> pacman -Su --needed --noconfirm
warning: database file for 'ucrt64' does not exist (use '-Sy' to download)
:: Starting core system upgrade...
 there is nothing to do
:: Starting full system upgrade...
error: failed to prepare transaction (could not find database)
MSYS2 system update (optional) failed
Traceback (most recent call last):
        16: from C:/tools/ruby2.5.8-2x64/bin/ridk.cmd:39:in `<main>'
        15: from C:/tools/ruby2.5.8-2x64/lib/ruby/site_ruby/2.5.0/ruby_installer/runtime/ridk.rb:14:in `run!'
        14: from C:/tools/ruby2.5.8-2x64/lib/ruby/site_ruby/2.5.0/ruby_installer/runtime/ridk.rb:99:in `install'
        13: from C:/tools/ruby2.5.8-2x64/lib/ruby/site_ruby/2.5.0/ruby_installer/runtime/components_installer.rb:35:in `install'
        12: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:110:in `top_level'
        11: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:125:in `run_with_threads'
        10: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:116:in `block in top_level'
         9: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:116:in `each'
         8: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:116:in `block (2 levels) in top_level'
         7: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/application.rb:160:in `invoke_task'
         6: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:183:in `invoke'
         5: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:194:in `invoke_with_call_chain'
         4: from C:/tools/ruby2.5.8-2x64/lib/ruby/2.5.0/monitor.rb:235:in `mon_synchronize'
         3: from C:/tools/ruby2.5.8-2x64/lib/ruby/gems/2.5.0/gems/rake-12.3.3/lib/rake/task.rb:214:in `block in invoke_with_call_chain'
         2: from C:/tools/ruby2.5.8-2x64/lib/ruby/site_ruby/2.5.0/ruby_installer/runtime/components/02_pacman_update.rb:16:in `execute'
         1: from C:/tools/ruby2.5.8-2x64/lib/ruby/site_ruby/2.5.0/ruby_installer/runtime/msys2_installation.rb:198:in `with_msys_apps_enabled'
C:/tools/ruby2.5.8-2x64/lib/ruby/site_ruby/2.5.0/ruby_installer/runtime/components/02_pacman_update.rb:46:in `block in execute': pacman failed (RuntimeError)
---> removing non-system ruby from current environment
    2.5.8-2-x64 : ruby 2.5.8p224 (2020-03-31 revision 67882) [x64-mingw32]
    ```

[sanfrancrisko]

After further conversation, we can use the Windows server runners Github provide in their Actions workflows. No requirement to use GCP.