Acceptance tests on Linux using Github Actions Workflow

[sanfrancrisko]

Feature Description

In the continuing effort (see #GH-958) to remove the dependencies on Travis and AppVeyor, we should have acceptance tests running on Github Actions.

For Linux, a self hosted runner that spins up a Docker container that either is preconfigured or configured with the same Ruby versions of the supported Puppet Agents the PDK ships with. This is currently:

• 2.5
• 2.7

Acceptance Criteria

• Executes the acceptance:local_parallel Rake task
• Will execute against Ruby 2.5 on the ruby:2.5 Docker container
• Will execute against Ruby 2.7 on the ruby:2.7 Docker container

[sanfrancrisko]

A few points of conversation:

Ruby Versions & Docker Containers

I'm suggesting that we pull the Docker containers that are available on the official Ruby Docker hub. This will mean that we take what we're given in regards to the base image of the Ruby tag we're pulling. Currently that would be:

Tag 2.5

• Base OS: Debian 9 (Stretch)
• Ruby Version: 2.5.8

Tag 2.7

• Base OS: Debian 10 (Buster)
• Ruby Version: 2.7.2

This allows us to introduce more variety in OSs than our current Travis based CI tests. It also means we're pulling the latest version of each Ruby version, as the X.Y tags will resolve to the latest builds - I'm sure it can be argued that this has both it's good and bad points. The good - we catch any potential compatibility issues earlier, but let's have that conversation if people feel strongly against it. There may be reasons we want to stay more in control of the Ruby versions we're testing against that I have not considered.

In regard to the base OSs, we may also feel that we want to be more in control of that. Currently, we would have (somewhat) parity with the current CI pipeline on Travis. Somewhat being Debian instead of Ubuntu. It would be nice to introduce more variety of platforms to execute acceptance tests against but that feels more of a stretch goal and separate discussion.

Acceptance Rake Task

The acceptance:local_parallel Rake task seems to encompass the test coverage we're interested in and therefore is the only one required:

• acceptance:local: excludes tests with package tag
• acceptance:smoke: excludes tests with package tag; only runs spec/acceptance/bundle_spec.rb

[sanfrancrisko]

Keeping this discussion as-is, but:

Dropping Ruby 2.7 as part of the acceptance criteria and raising as a separate issue - more work than anticipated.