(GH-501) Remove legacy facts gem #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the template logic that adds `puppet-lint_legacy_facts-checl` based on `common:disable_legacy_facts` config and fixes #501. The legacy facts check is now part of puppet-lint which means including this gem is no longer required. Additionally, users that currently have `disable_legacy_facts` set to `true` in their `.sync` file may encounter breaking dependency conflicts.
jordanbreen28
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the template logic that adds
puppet-lint_legacy_facts-checlbased oncommon:disable_legacy_factsconfig and fixes #501.The legacy facts check is now part of puppet-lint which means including this gem is no longer required.
Additionally, users that currently have
disable_legacy_factsset totruein their.syncfile may encounter breaking dependency conflicts.