You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commit 7bc38cc that solves FACT-3202 has broken libvirt-lxc containers detection
Warning: Facter: Container runtime, 'lxc-libvirt', is unsupported, setting to 'container_other'
Before the commit facter code in read_cgroup matched "lxc" on a prefix match, that is any container runtime that was named with prefix "lxc" would have satisfied the test, and an environment string "container=lxc-libvirt" will be detected as a container runtime
Thanks @turchanov@lollipopman and I were discussing whether it should be a prefix or exact match in #2741 (comment) And it sounds like prefix match is preferred. Can you describe steps to reproduce like I did in #2741 (comment)
Sorry for delay, I am struggling to provide steps to reproduce the bug... (We have a custom procedure to setup lxc containers in libvirt, and I am still looking for the solution)
Commit 7bc38cc that solves FACT-3202 has broken libvirt-lxc containers detection
Before the commit facter code in
read_cgroup
matched "lxc" on a prefix match, that is any container runtime that was named with prefix "lxc" would have satisfied the test, and an environment string "container=lxc-libvirt" will be detected as a container runtimehttps://github.com/puppetlabs/facter/blame/05e4387c8de085a44ff5cfbe02081703dbbf5d60/lib/facter/resolvers/containers.rb#L27
The text was updated successfully, but these errors were encountered: