Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): respect environment proxy config when downloading Firef… #6577

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

benelliott
Copy link
Contributor

…ox version metadata on install

Issues: #6573

Copy link
Contributor

@mjzffr mjzffr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matt-glich
Copy link

Appreciate the help!

@gamma032steam
Copy link

Do we need a documentation update?

HTTP_PROXY, HTTPS_PROXY, NO_PROXY - defines HTTP proxy settings that are used to download and run Chromium.

Perhaps
"HTTP_PROXY, HTTPS_PROXY, NO_PROXY - defines HTTP proxy settings that are used to download and run a browser.".

@jschfflr
Copy link
Contributor

@benelliott Could you verify that this change is still relevant and if yes, please update it? Happy to get this landed :)

@google-cla
Copy link

google-cla bot commented Sep 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 15, 2021
@google-cla
Copy link

google-cla bot commented Sep 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@jschfflr
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 15, 2021
@jschfflr jschfflr enabled auto-merge (squash) September 15, 2021 13:27
@jschfflr jschfflr merged commit 9399c97 into puppeteer:main Sep 15, 2021
@benelliott
Copy link
Contributor Author

Thanks @jschfflr!

@jschfflr
Copy link
Contributor

Sure! Happy to help :)

This was referenced May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants