Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reading gitAuthSecret from other secret sources than kubernetes secret #131

Closed
sfc-gh-jelsesiy opened this issue Apr 1, 2021 · 0 comments · Fixed by #132
Closed

Allow reading gitAuthSecret from other secret sources than kubernetes secret #131

sfc-gh-jelsesiy opened this issue Apr 1, 2021 · 0 comments · Fixed by #132
Assignees
@viveklak
Labels
emergent An issue that was added to the current milestone after planning kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.54

Comments

@sfc-gh-jelsesiy
Copy link

This is a continuation of #122 which was addressed recently via #125.

While it's now possible to read cloud provider credentials or the pulumi access token from various sources, the gitAuthSecret is still bound to be a kubernetes secret. This requires operators who want to use services like Vault to use another secret source just for this one secret.

I envision this to work the exact same way like envRefs have been implemented.
@sfc-gh-jelsesiy sfc-gh-jelsesiy added the kind/enhancement Improvements or new features label Apr 1, 2021
@mikhailshilkov mikhailshilkov added kind/enhancement Improvements or new features and removed kind/enhancement Improvements or new features labels Apr 1, 2021
@viveklak viveklak mentioned this issue Apr 2, 2021
Merged
@viveklak viveklak added the emergent An issue that was added to the current milestone after planning label Apr 2, 2021
@viveklak viveklak added this to the 0.54 milestone Apr 2, 2021
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viveklak viveklak

Labels
emergent An issue that was added to the current milestone after planning kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.54
Development

Successfully merging a pull request may close this issue.

Adding resource ref variant for GitAuthSecret pulumi/pulumi-kubernetes-operator
4 participants
@viveklak @mikhailshilkov @pulumi-bot @sfc-gh-jelsesiy