Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose metrics #123

Closed
sfc-gh-jelsesiy opened this issue Mar 23, 2021 · 4 comments · Fixed by #217
Closed

Expose metrics #123

sfc-gh-jelsesiy opened this issue Mar 23, 2021 · 4 comments · Fixed by #217
Assignees
@viveklak
Labels
customer/feedback Feedback from customers ga-blocker Blocks 1.0 GA good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.63

Comments

@sfc-gh-jelsesiy
Copy link

To gain visibility into reconciliation latency, errors, usual resource metrics such as CPU, mem, fd usage etc. it would be good if the pulumi-operator would implement at minimum the controller-runtime default metrics, see here.
@sfc-gh-jelsesiy sfc-gh-jelsesiy added the kind/enhancement Improvements or new features label Mar 23, 2021
@komalali komalali added kind/enhancement Improvements or new features and removed kind/enhancement Improvements or new features labels Mar 25, 2021
@viveklak
Copy link
Contributor

FWIW we do get the default metrics from the operator SDK and the endpoint is available at 0.0.0.0:8383 on the pod. Probably need to update the spec with the appropriate scraping annotations. If there is a standard set we should add - happy to take a contribution on this front.

@viveklak viveklak added the good-first-issue Start here if you'd like to start contributing to Pulumi label Apr 29, 2021
@sfc-gh-mtreadwell
Copy link

Adding on to this, I think having some of the following metrics for stack info would be nice (for the endpoint on 0.0.0.0:8686).

  • Update duration
  • Number of stacks currently updating/reconciling
  • Number of stacks with last update failed
  • Number of stacks
  • Total number of updates (along with failures/success)
  • Number of resources created/modified/deleted

@sfc-gh-mtreadwell
Copy link

@viveklak Are there any updates or plans to implement this on the Pulumi side?

@mikhailshilkov mikhailshilkov added the customer/feedback Feedback from customers label Sep 27, 2021
@viveklak
Copy link
Contributor

@viveklak Are there any updates or plans to implement this on the Pulumi side?

This is on our prioritized backlog. The team is currently working towards some time-sensitive releases but we intend to have support for this by end of October. Thanks for your patience.

@mikhailshilkov mikhailshilkov added this to the 0.63 milestone Oct 6, 2021
@viveklak viveklak added the ga-blocker Blocks 1.0 GA label Oct 7, 2021
@viveklak viveklak mentioned this issue Oct 7, 2021
Closed
@viveklak viveklak self-assigned this Oct 8, 2021
@viveklak viveklak mentioned this issue Oct 8, 2021
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viveklak viveklak

Labels
customer/feedback Feedback from customers ga-blocker Blocks 1.0 GA good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.63
Development

Successfully merging a pull request may close this issue.

Add metrics support pulumi/pulumi-kubernetes-operator
6 participants
@viveklak @mikhailshilkov @komalali @pulumi-bot @sfc-gh-jelsesiy @sfc-gh-mtreadwell