Skip to content

Commit 0005b1a

Browse files
Kris686krzysztofer9dirien
authored
prometheus monitoring fix - missing label (#519)
### Issue description Pulumi kubernetes operator creates Service and ServiceMonitor objects for metrics by itself: https://github.com/pulumi/pulumi-kubernetes-operator/blob/7d9e693bc6e27f1e3881ce350cdf7fbde71b26be/cmd/manager/main.go#L186C31-L186C31 Service created for metrics requires name label added on pods. ### Proposed changes Added "name" label with {{ template "pulumi-kubernetes-operator.name" . }} value to pulumi-kubernetes-operator Deployment at ReplicaSet level. impact/no-changelog-required --------- Co-authored-by: krzysztofer <[email protected]> Co-authored-by: Engin Diri <[email protected]>
1 parent 4a92c65 commit 0005b1a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

deploy/helm/pulumi-operator/Chart.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ icon: https://www.pulumi.com/logos/brand/avatar-on-white.svg
99

1010
type: application
1111

12-
version: 0.7.2
12+
13+
version: 0.7.3
1314
appVersion: 1.14.0
1415

1516
keywords:
@@ -25,7 +26,7 @@ maintainers:
2526
annotations:
2627
artifacthub.io/containsSecurityUpdates: "false"
2728
artifacthub.io/changes: |
28-
- Fix type in CRD
29+
- Added "name" label with pulumi-kubernetes-operator.name value to pulumi-kubernetes-operator Deployment at ReplicaSet level. (#519)
2930
artifacthub.io/images: |
3031
- name: pulumi-kubernetes-operator
3132
image: docker.io/pulumi-kubernetes-operator:v1.14.0

deploy/helm/pulumi-operator/templates/deployment.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ spec:
2424
{{- toYaml . | nindent 8 }}
2525
{{- end }}
2626
labels:
27+
name: {{ template "pulumi-kubernetes-operator.name" . }}
2728
app: {{ template "pulumi-kubernetes-operator.name" . }}
2829
release: {{ .Release.Name }}
2930
{{- include "pulumi-kubernetes-operator.selectorLabels" . | nindent 8 }}

0 commit comments

Comments
 (0)