From 997dd96328800f9d25b1577f6585a6311c265fa7 Mon Sep 17 00:00:00 2001 From: Bryce Lampe Date: Mon, 29 Sep 2025 15:46:57 -0700 Subject: [PATCH 1/4] Fix missing password in tests --- .github/workflows/build-test.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 7252f2c6fb1b..0fd35088d066 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -240,6 +240,8 @@ jobs: env: # specifying this id will cause the OIDC test(s) to run against this AD application OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }} + ARM_CLIENT_SECRET: ${{ steps.esc-secrets.outputs.ARM_CLIENT_SECRET }} + ARM_CLIENT_CERTIFICATE_PASSWORD_FOR_TEST: ${{ steps.esc-secrets.outputs.ARM_CLIENT_CERTIFICATE_PASSWORD }} run: | set -euo pipefail cd examples && go test -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log @@ -296,6 +298,8 @@ jobs: env: # specifying this id will cause the OIDC test(s) to run against this AD application OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }} + ARM_CLIENT_SECRET: ${{ steps.esc-secrets.outputs.ARM_CLIENT_SECRET }} + ARM_CLIENT_CERTIFICATE_PASSWORD_FOR_TEST: ${{ steps.esc-secrets.outputs.ARM_CLIENT_CERTIFICATE_PASSWORD }} run: | set -euo pipefail cd examples && \ From f11831b0e0d0f4a292128d8089290dd742027daa Mon Sep 17 00:00:00 2001 From: Bryce Lampe Date: Tue, 30 Sep 2025 09:06:30 -0700 Subject: [PATCH 2/4] temporarily force long tests on pr --- .github/workflows/build-test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 0fd35088d066..454c0c14408c 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -236,7 +236,7 @@ jobs: echo "AZURE_CONFIG_DIR_FOR_TEST=$HOME/.azure.tmp" >> "$GITHUB_ENV" - name: Run tests - if: ${{ ! inputs.short_test }} + # if: ${{ ! inputs.short_test }} env: # specifying this id will cause the OIDC test(s) to run against this AD application OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }} @@ -247,7 +247,7 @@ jobs: cd examples && go test -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log - name: Run short tests - if: inputs.short_test + # if: inputs.short_test run: | set -euo pipefail cd examples && go test -cover -timeout 15m -short -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log @@ -294,7 +294,7 @@ jobs: df -h - name: Run pulumi/examples tests - if: ${{ !inputs.short_test }} + # if: ${{ !inputs.short_test }} env: # specifying this id will cause the OIDC test(s) to run against this AD application OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }} From 2a56bb2c45be7b579da761ae48ec53b12ae95a7b Mon Sep 17 00:00:00 2001 From: Bryce Lampe Date: Tue, 30 Sep 2025 09:19:18 -0700 Subject: [PATCH 3/4] fix lint --- .github/actionlint.yaml | 5 +++++ .github/workflows/build-test.yml | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/actionlint.yaml b/.github/actionlint.yaml index 76090a4dbe3a..c954737a424e 100644 --- a/.github/actionlint.yaml +++ b/.github/actionlint.yaml @@ -1,3 +1,8 @@ self-hosted-runner: labels: - pulumi-ubuntu-8core + +paths: + ".github/workflows/build-test.yml": + ignore: + - 'property "esc-secrets" is not defined in object type {}' diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 454c0c14408c..0fd35088d066 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -236,7 +236,7 @@ jobs: echo "AZURE_CONFIG_DIR_FOR_TEST=$HOME/.azure.tmp" >> "$GITHUB_ENV" - name: Run tests - # if: ${{ ! inputs.short_test }} + if: ${{ ! inputs.short_test }} env: # specifying this id will cause the OIDC test(s) to run against this AD application OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }} @@ -247,7 +247,7 @@ jobs: cd examples && go test -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log - name: Run short tests - # if: inputs.short_test + if: inputs.short_test run: | set -euo pipefail cd examples && go test -cover -timeout 15m -short -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 16 . 2>&1 | tee /tmp/gotest.log @@ -294,7 +294,7 @@ jobs: df -h - name: Run pulumi/examples tests - # if: ${{ !inputs.short_test }} + if: ${{ !inputs.short_test }} env: # specifying this id will cause the OIDC test(s) to run against this AD application OIDC_ARM_CLIENT_ID: ${{ inputs.oidc_arm_client_id }} From 16f95f5a76794259aa30a74da7a1ec037e765144 Mon Sep 17 00:00:00 2001 From: Bryce Lampe Date: Tue, 30 Sep 2025 09:25:23 -0700 Subject: [PATCH 4/4] update azurelint --- .github/workflows/actionlint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/actionlint.yml b/.github/workflows/actionlint.yml index feccb222a877..baaee4d7b689 100644 --- a/.github/workflows/actionlint.yml +++ b/.github/workflows/actionlint.yml @@ -17,6 +17,6 @@ jobs: uses: actions/checkout@v4 - name: Lint actions - uses: reviewdog/action-actionlint@v1.57.0 + uses: reviewdog/action-actionlint@v1.67.0 with: actionlint_flags: "-config-file .actionlint.yml"