Improve download behavior #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix #24. This ensures that it adds the gluon dir rather than a file names gluon.
The primary justification for this is adding/updating extensions. Ideally, you should just be able to run `download` again to get the new extensions, which the current implementation does not allow for.
|
I personally suggest adding some kind of force argument, but that isn't necessary. |
splatboydev
reviewed
Nov 14, 2022
splatboydev
reviewed
Nov 14, 2022
trickypr
commented
Nov 15, 2022
| log.info("'engine/' is empty, deleting contents...") | ||
| rmSync(ENGINE_DIR, { recursive: true }) | ||
|
|
||
| } |
There was a problem hiding this comment.
Do you mean if it isn't empty? If firefox has already been downloaded, it will skip downloading it and go to downloading addons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few problems with download that this solves:
a) There isn't enough logging, especially with GitHub addons, to be helpful in error reports
b) Download didn't allow you to download extensions without redownloading
engine/(regression from #25)@splatboydev because this is changing behavior, can you review this?