Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry / Bug Reporting #1013

Open
5 tasks done
a-n-d-r opened this issue May 27, 2024 · 3 comments
Open
5 tasks done

Telemetry / Bug Reporting #1013

a-n-d-r opened this issue May 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@a-n-d-r
Copy link

a-n-d-r commented May 27, 2024

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

Today I've installed Pulsar on a new machine, checked my config.cson and noticed this:

"*":
  "exception-reporting":
    userId: "123e4567-e89b-12d3-a456-426614174000"

Didn't found anything related to telemetry / bug reports in the settings.
After 5 minutes of search, found the core package "exception-reporting" that sends the reports to "bugsnag.com" website.

I think that we should add checkbox in the Settings --> Core --> Telemetry / Bug Reporting to turn on/off bug reports.
Then, we have 2 ways:

  • Leave bug reports opt-out and change the Privacy Policy of Pulsar.
  • Make bug reports opt-in.

Also, we may ask user about bug reports on a first launch of Pulsar.

Pulsar version

1.117.0

OS details

Platform-independent

What steps are needed to reproduce this?

  1. Install Pulsar
  2. Open config.cson configuration file
@a-n-d-r a-n-d-r added the bug Something isn't working label May 27, 2024
@a-n-d-r
Copy link
Author

a-n-d-r commented May 27, 2024

Related to #40

@confused-Techie
Copy link
Member

So I'll add quickly onto this. As you can see when I did #40, there was a single change I made to the exception-reporting package.

That was in a function titled shouldReport I changed it to always return false. That's because Atom would check this function prior to ever reporting to see if users had opted out of reporting. So with this function always returning false that means it assumes every single user has opted out, and it should never report anything to bugsnag.

Plus the Pulsar team has never even configured bugsnag, so there's no telemetry we would even be able to see if it was reporting there.


So this is to say, that no we are not currently collecting telemetry from any of our users, and our Privacy Policy should still be 100% accurate.

But I can absolutely see how the description of the exception-reporting package could be misleading, especially as it's writing values to user's config files. Considering we never did repurpose the exception-reporting package to log to local files like I had wanted, maybe it's time that we consider removing it entirely.

@a-n-d-r
Copy link
Author

a-n-d-r commented May 28, 2024

Oh, I guess I didn't notice that this package was disabled in #40, apologies.

But I can absolutely see how the description of the exception-reporting package could be misleading, especially as it's writing values to user's config files. Considering we never did repurpose the exception-reporting package to log to local files like I had wanted, maybe it's time that we consider removing it entirely.

I agree, it would be great to remove that package from Pulsar, since it does nothing but take place in config and misleading users.

Btw, thank you so much for Pulsar! It is awesome to use code editor I'm familiar with, regardless of Github/Microsoft decisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants