remove wildcard for .ck
, replace with list of 2LDs
#2250
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of 2LDs taken from https://en.wikipedia.org/wiki/.ck#Requirements_of_.ck_registration.
I would recommend removing the wildcard and specifying the 2LDs specifically, just in the event they allow 2nd level registrations, it won't affect anyone attempting to set cookies at the second level.
This PR isn't super urgent, and won't affect any active domains once deployed.
The
!www.ck
entry has been removed in favour of specifying the TLD itself.