-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sslip.io
to private list
#2206
Conversation
sslip.io is a DNS service that, when queried with a hostname with an embedded IP address, returns that IP address, e.g. 127-0-0-1.sslip.io resolves to 127.0.0.1. This fits the category of a domain that "issue subdomains to mutually-untrusting parties". Side note: creating the DNS and _PSL TXT style record requires a code change, so I may try that next time I do a deploy, but that's only every few months.
We want to place sslip.io on the Public Suffix List so we don't need to pester Let's Encrypt for rate limit increases. According to https://publicsuffix.org/submit/: > owners of privately-registered domains who themselves issue subdomains to mutually-untrusting parties may wish to be added to the PRIVATE section of the list. References: - https://publicsuffix.org/ - publicsuffix/list#2206 [Fixes #57]
I noticed in your commit cunnie/sslip.io@0c3c5aa, you are attempting to get around Let's Encrypt rate limits by applying to the PSL. If you are only applying for the sole purpose of evading that limit, we request you resolve it with LE directly. However it should be fine as it seems you are applying for cookie separation due to each subdomain belonging to a different party (please correct me if I'm wrong). |
Wow, @wdhdev , I am impressed with your responsiveness! It was but a draft PR, and you chimed in with a helpful comment! You're my hero! |
No worries! I've known about your service for a while as it is used by default with the Coolify.io project, so thought I'd just give a early review to save some time, I'm aware everything might not be in order yet as it is a draft PR :) (Also just an FYI, I'm not a maintainer of the PSL, I'm simply a volunteer) |
Unfortunately, as currently stated in the Non-Acceptance Factors:
That said, a relevant discussion thread remains open at #1349 |
The obvious issue with using IP-based domains is that, if an IP gets reassigned to a different user it creates an opportunity for a MitM attack for the previous user who may still have a valid certificate. While this may be unlikely or difficult to control, people place a lot of trust in secure connections and jeopardizing them is unacceptable. Most similar services which are on the PSL use hashes or randomized hostnames to make them unique per user. |
ngrok does the same however and they are listed on the PSL. Last time I checked, they use the host's IP address in the hostname. |
The reasoning for not doing it is also explained in this old comment by Ryan: #1349 (comment)
And there is an exception we have been making for organizations which ensure that only their own IP address space is used and who are therefore in a position to control usage and warn users.
I don't know ngrok so I cannot immediately speak to that but in their most recent PR they stated:
Note: Personally, I am not such a big fan of hashes or other long randomized identifiers for anything a user might see. It's just an opportunity for social engineering because users will not check them. |
Hey @simon-friedberger @wdhdev @groundcat I'm closing this PR; based on your thoughtful, timely, and nuanced discussion, I feel that sslip.io doesn't fit the acceptance criteria. I can't thank you enough for reviewing my PR, and for all the work maintaining the Public Suffix List. You're the unsung heroes of the internet. I'll check in periodically to see if the acceptance criteria changes, and may re-open the request if that's the case. |
Public Suffix List (PSL) Submission
Checklist of required steps
Description of Organization
Robust Reason for PSL Inclusion
DNS verification via dig
Run Syntax Checker (
make test
)Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the
_psl
TXT record in place in the respective zone(s).Submitter affirms the following:
For PRIVATE section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.
To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.
PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.
(Link: about propagation/expectations)
Description of Organization
sslip.io is a DNS service that, when queried with a hostname with an embedded IP address, returns that IP address, e.g. 127-0-0-1.sslip.io resolves to 127.0.0.1. This makes sslip.io a private domain that "issues subdomains to mutually-untrusting parties". I certainly don't trust some of these parties — although most sslip.io users are legitimate, a small minority are scammers, hucksters, and grifters, and for those a maintain a blocklist of IP addressesses that don't resolve.
I'm Brian Cunnie, [email protected], and I run sslip.io. I wrote almost all the code, and I maintain the four DNS name servers of sslip.io.
Organization Website: https://sslip.io
Reason for PSL Inclusion
I'd like to be included in the PSL for cookie separation due to each subdomain belonging to a different party. And, like I said earlier, some of these parties are completely untrustworthy.
In the spirit of transparency, know that I have a rate limit increase request open with Let's Encrypt, but they've been very responsive with previous rate limit increases, and is not the reason why I'm requesting being added to the PSL.
Number of users this request is being made to serve:
Tens of thousands of users; it's hard to get an exact number, but I know that the servers respond to 7,000+ DNS queries/second.
DNS Verification
Results of Syntax Checker (
make test
)