-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hop.sh
#1612
Add hop.sh
#1612
Conversation
Apologies for the bump, but it's been almost a year. Over 1m users are hitting these domains now. @dnsguru |
The entire .hop.sh domain got flagged by Google Safebrowsing as phishing, in turn flagging thousands of websites which use the hop.sh subdomain. Please could this PR be looked at! |
If a browser flags a security issue indicating there is phishing activity, there is likely evidenced phishing activity that earned it being flagged. If the point is being made that the volunteers processing this sooner would have minimized the impact of the flag to the offending subdomain and avoided the browser determining the submitted base eTLD+ as an unsafe namespace, how is this really a compelling argument for volunteers, who are donating their time to this project, to expedite a PR that enables any phishing? |
Fair observation, however...
|
Hop customer here — even though I don't directly use hop.sh for my website, this issue is still affecting my users because my website makes a request to my API, which uses a hop.sh subdomain. The notice pops up for users when the request is made. Frustrating for every party. |
Google Safebrowsing just flagged us again. I don't think it's fair that all of our competitors are gracefully added to the PSL without question while we have to wait over a year and suffer consequences. (and yes, Google Core libraries use the PSL to parse TLDs: https://github.com/google/guava/wiki/InternetDomainNameExplained) |
PSL is not intended for use to bypass security safeguards - or to infer any security. it is a catalog. That said, riskier stuff may sometimes take longer to review. Is there an assertion being made here that hop.sh (now blocked multiple times by google safe browsing due to some cause which is typically abuse) platform is somehow a victim of some form of competitive favoritism? I get you might have feels but that's a message that contains a bit of a microagression. We're just volunteers and there is a queue ahead of this request. We have flagged this as requiring further security review once you notified us about the prior situation where the domain was similarly flagged by google - and we are awaiting any volunteer in the security community to weigh in and comment that it does not have risks and can proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- hop.sh expires 2024-06-01
- DNS _psl entries
- Tests pass
- Sorting according to guidelines
- Reasoning/Organization description
@@ -12400,6 +12400,10 @@ homesklep.pl | |||
// Submitted by SECaaS Team <[email protected]> | |||
secaas.hk | |||
|
|||
// Hop : https://hop.io | |||
// Submitted by Phineas Walton <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, please provide a non-personal email address.
Given the amount of times this namespace has experienced gating by safe browsing, the PR was flagged with security review - the main concern being that abusive activity that earns itself the joy of the red screen seems to be impacted by an entry in the PSL - it seems to alter the computations of bad actor tallies so that an entire domain is not nerfed. The concerns raised by security folk is that with such browser safety initiatives needing to take prompt action to safeguard users, namespaces that get added to the PSL will buy themselves extended operation of campaigns if requested by bad actors. This is more a meta-coversation - there is no suggestion that the hop.sh namespace is a bad namespace or a good namespace, only that some bad actors found a way to get it onto the safe browsing list. Even absent the safe browsing friction, requests must have an expiration date at least 2 years from now to approve this pull request. Registry shows it expires in under three months. |
@simon-friedberger I removed the approval until we see the name is extended out at least 2 years. |
Just checking with NameCheap - they allow for up to 9 year renewals so this is not a situation whereby the TLD registry or registrar disallows the name to be extended further. Extending the name would provide some indicia of non-ephemoral existence to the requested namespace, especially given its dance with safe browsing |
@Phineas Any updates? |
Description of Organization
Reason for PSL Inclusion
DNS verification via dig
Run Syntax Checker (make test)
Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section
Submitter affirms the following:
For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.
To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.
PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.
(Link: about propagation/expectations)
Description of Organization
Hop allows developers to deploy Docker images & applications directly from GitHub. Once deployed, customers can attach a "gateway" to expose their deployment to the internet - when they do this, we assign a free
.hop.sh
domain to them. Customers can also add custom domains, but for smaller projects, developers often opt to use the free.hop.sh
domains instead.Organization Website:
https://hop.io
Reason for PSL Inclusion
Number of users this request is being made to serve: 2000+
DNS Verification via dig
Results of Syntax Checker (
make test
)