Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncommenting nsw.gov.au #1418

Closed
wants to merge 3 commits into from
Closed

Conversation

nasser-snsw
Copy link

Uncommenting nsw.gov.au.

  • Description of Organization
    The Government of New South Wales, also known as the NSW Government, is the Australian state democratic administrative authority of New South Wales. The submitter of this Pull request ([email protected]) works for Service NSW, which is a New South Wales Government executive agency within the Department of Customer Service that provides a one-stop access to government services via online, phone or in-person at its service centres.

  • Reason for PSL Inclusion
    Already included in PSL, but has been commented out [1]. Not clear on the reason why it was commented out, change was made 12 years ago. Required to be uncommented to address incorrect organisational domain alignment as per rfc7489.
    Duplicate of issue (Created by different department):
    nsw.gov.au (and nt.gov.au) incorrectly commented out #788

  • DNS verification via dig
    dig TXT _psl.nsw.gov.au
    https://github.com/publicsuffix/list/pull/
    Record will be created once pull req ID known.

  • Run Syntax Checker (make test)
    https://hastebin.com/iyoxeguhum.makefile

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=547985

@dnsguru dnsguru self-assigned this Sep 11, 2021
@dnsguru dnsguru added NOT IOS FB Submitter attests PR is not #1245 related 🩺 pending-validation Something needs to be validated 😭rollback Requestor seeking to remove or revise an entry labels Sep 11, 2021
@dnsguru
Copy link
Member

dnsguru commented Sep 12, 2021

Update the ticket once the validation record is in place, please.

*** one.one.one.one can't find _psl.nsw.gov.au: Non-existent domain
*** dns.google can't find _psl.nsw.gov.au: Non-existent domain
*** dns9.quad9.net can't find _psl.nsw.gov.au: Non-existent domain

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a sorting nit, but to comply with the submission guidelines, nsw.gov.au would come before nt.gov.au in the list.

Can you re-arrange those two lines back into their original order?

@dnsguru dnsguru added ❌FAIL - DNS VALIDATION Unable to confirm _PSL TXT = This PR # (also see #1439) ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important labels Sep 12, 2021
@dnsguru
Copy link
Member

dnsguru commented Sep 13, 2021

@nasser-snsw nudge

@dnsguru
Copy link
Member

dnsguru commented Oct 6, 2021

Still getting a hot cup of nope from DNS on validating this

; <<>> DiG 9.11.5-P4-5.1+deb10u5-Debian <<>> TXT _psl.nsw.gov.au
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 46126
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;_psl.nsw.gov.au.               IN      TXT

;; AUTHORITY SECTION:
nsw.gov.au.             900     IN      SOA     q.au. noc.afilias-nst.info. 1530578223 10800 3600 2764800 900

;; Query time: 30 msec
;; SERVER: 66.33.200.80#53(66.33.200.80)
;; WHEN: Wed Oct 06 08:46:32 PDT 2021
;; MSG SIZE  rcvd: 102

@peter-bertok
Copy link

Please do not go ahead with this change, as it can potentially break existing applications. DCS and CyberNSW are running a project at the moment to investigate the impact of adding nsw.gov.au to the PSL. That report is not yet ready, as most of the affected departments have only been notified of the planned change recently.

@dnsguru
Copy link
Member

dnsguru commented Oct 22, 2021

no action will be taken without the DNS validation records placed in the zone

@nasser-snsw
Copy link
Author

Will be closing this PR - our parent cluster will submit a new one.

@SimonJHaynes
Copy link

Please do not go ahead with this change, as it can potentially break existing applications. DCS and CyberNSW are running a project at the moment to investigate the impact of adding nsw.gov.au to the PSL. That report is not yet ready, as most of the affected departments have only been notified of the planned change recently.

Please advise when this change will be implemented as not having nsw.gov.au in the PSL is breaking DMARC authentication for subdomains.

@dnsguru
Copy link
Member

dnsguru commented Nov 3, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌FAIL - DNS VALIDATION Unable to confirm _PSL TXT = This PR # (also see #1439) ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important NOT IOS FB Submitter attests PR is not #1245 related 🩺 pending-validation Something needs to be validated 😭rollback Requestor seeking to remove or revise an entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants