Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the expected public suffix of leading dot domains #887

Open
sethmlarson opened this issue Sep 25, 2019 · 1 comment
Open

Clarify the expected public suffix of leading dot domains #887

sethmlarson opened this issue Sep 25, 2019 · 1 comment

Comments

@sethmlarson
Copy link

The test cases using checkPublicSuffix() take the domain and the expected privately registered domain as input but don't have any checks for what the public suffix of the domain is. In many cases this is just the privately registered domain minus the leading label. (Or all labels in the null case)

For a domain like .example.com which is expected to return null for the private domain, what is the expected "public suffix": null, example.com?

Is there any way that the test cases can be expanded to also include what the public suffix of a given domain should be?

@simon-friedberger
Copy link
Contributor

@sethmlarson Could you clarify what exactly you are trying to accomplish?

Afaiu .example.com is technically not a domain, plus our general stance is that the PSL is only a list and is up for interpretation (mostly because people cannot agree on what it should mean).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants