Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine/reword GitHub Issue labels for clarity, legibility & friendliness #9533

Open
jywarren opened this issue Apr 20, 2021 · 27 comments
Open
Labels
brainstorm Issues that need discussion and requirements need to be elucidated break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration discussion fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute

Comments

@jywarren
Copy link
Member

I just added several new labels (https://github.com/publiclab/plots2/labels) to this issue, and it occurred to me that we could do some work to make labels clearer, more legible and most importantly, friendlier!

#9510 (comment)

image

They're not super legible though, and not all have descriptions:

image

We have an existing collection of label descriptions in this file:

https://github.com/publiclab/plots2/blob/main/doc/LABELS.md

Let's do a few things with this:

  1. let's rephrase them to be extra friendly and readable, especially for newcomers and folks looking to get involved in supportive tasks (i.e. more emoji!!! ✨ )
  2. let's update the entries in the README file linked above!
  3. let's copy the descriptions into the labels system of GitHub at https://github.com/publiclab/plots2/labels
## Issue labels

For keeping the issues in a systematic way, we use labels which describe the type of issue, the  ` programming language ` used in the issue and so on.
Some of the most used labels are:-
* ` help-wanted ` which indicates the issue requires help by anyone willing to contribute.
* ` first-timers-only ` which are meant to welcome newcomers in the community. They need to be well-formatted using the *First-timers_Issue_Template*.
* ` fto-candidate ` issues are issues which are meant to be solved by **first timers** but they aren't well-formatted. These issues can be converted into ` first-timers-only ` issues using the friendly template.
* ` bug ` which tells that the issue is regarding one of our programs which faces problems when a certain task is executed.
* ` enhancement ` explains that the issue is to improve upon one of our existing features.
* ` planning ` - These issues can be used as a place for discussion on a long term or a big project.
* ` break-me-up ` says that this certain issue could be and should be broken into smaller self-contained projects for cleaner code separation, more discrete tests, and, easier and iterative collaboration.
* ` more-detail-please ` tells the issue lacks proper description and perhaps needs code links or the location of the problem.
* Labels like ` HTML ` , ` CSS ` , ` Ruby ` and ` JavaScript ` tell the **programming language** of the issue.
* ` design ` - This says that the issue requires more design work and discussion (i.e. mockups and sketches).
* ` documentation ` - This tells that a certain feature lacks proper documentation or needs more documents.
* ` testing ` - These issues are usually for adding `unit tests`, `integration tests` or any other tests for a particular feature/program.
* ` outreach ` - The outreach issues involve community involvement and helping people who're stuck somewhere.
* Some issues have been labeled with ` summer-of-code ` , ` outreachy ` , ` first-timers-only `, ` gci-candidate ` and ` rgsoc ` which mean that these issues have been reserved for students who're participating in these events.
* `brainstorm` - Issues that need discussion and requirements need to be elucidated

## Pull request labels
For faster review and adoption, we add labels to pull requests too.
Some commonly used PR labels are:-
* ` in-progress ` - This indicates that the pull request is still being worked upon.
* ` needs-help ` - This says that someone is stuck somewhere and needs help to figure that out.
* ` review-me ` - This means seeking for review from Public Lab reviewers.
* ` ready ` - This is used after using the ` review-me ` . This means that the PR is ready for merge.

For pull requests marked with *in progress*, *needs-help*, or *review-me*, here's a checklist of things you can ask for to help a project towards completion:

  * 🎉 encouragement 😄 👍
  * 🔗 links to original issues that they solve with fixes #0000 format in issue body
  * ✍️ more descriptive titles (for quick scanning down a list)
  * 🐞 debugging (if Travis tests did not pass)
  * 👩‍💻 any tips/suggestions on the code itself -- especially simplifying or reducing repetition, increasing readability
  * ✔️ tests to safeguard the new code
  * 📸 screenshots please, if it includes a new design or behavior!

Thanks, all!!!

@jywarren jywarren added help wanted requires help by anyone willing to contribute fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration brainstorm Issues that need discussion and requirements need to be elucidated discussion labels Apr 20, 2021
@Manasa2850
Copy link
Member

@jywarren this sounds great!! 🎉
I would like to help in creating FTOs for this!

@govindgoel
Copy link
Member

@jywarren this is really great and will surely help everyone.
I would surely like to work on opening FTOs.

@daemon1024
Copy link
Member

How about if we have codebase related labels like area/models, area/views, area/controllers and then have a detailed documentation for that saying

Hey, if an issue has area/comments label please checkout https://github.com/publiclab/plots2/tree/main/app/views/comments for performing relevant changes

@daemon1024
Copy link
Member

Some PR specific labels like tests-passing or needs-debugging if tests fail, so as to grab more attention from reviewers :)

@govindgoel
Copy link
Member

govindgoel commented Apr 20, 2021

Or maybe we can also add labels like build or dependency issue, which needs to be looked asap.

@daemon1024
Copy link
Member

dependabot PR's already have a dependency label I believe 🤔

@govindgoel
Copy link
Member

dependabot PR's already have a dependency label I believe 🤔

Yeah that's there but it's meant for if a PR update a dependency

@Manasa2850
Copy link
Member

Some PR specific labels like tests-passing or needs-debugging if tests fail, so as to grab more attention from reviewers :)

This sounds great! We can also have labels like PR:unreviewed and PR:reviewed-changes-requested which is automated depending on whether a reviewer has reviewed and/or suggested changes. I have seen something similar in the dev.to repository. This would make things easier for reviewers! 😃

@daemon1024
Copy link
Member

daemon1024 commented Apr 20, 2021

That's a great suggestion. We can maybe leverage some github-actions to automate a lot of labeling here.

@Elukoye
Copy link
Contributor

Elukoye commented Apr 20, 2021

@daemon1024 ,I have been learning about GitHub actions ,would like to work on your suggestion once it is accepted / agreed upon.

@Elukoye
Copy link
Contributor

Elukoye commented Apr 20, 2021

Here are some label ideas we could use;
-new idea 💡 ~> for introducing new features or functionality.
-refactor 🔄 ~> for code that needs refactoring or optimization.
-inactive 🚫 ~> no action needed ,out of production or already fixed.
-lightweight 🧘‍♀️ ~> for issues that are non technical but necessary e.g restructuring folders.

@jywarren
Copy link
Member Author

These are great ideas, folks, and thanks especially to @Elukoye for these suggestions! I'm really interested in the exact wording and how it can be friendly.

Let's present them in this format for discussion here:

  • break-me-up - break up for cleaner code separation, discrete tests, and, easier and iterative collaboration

https://github.com/publiclab/plots2/labels has a lot already so let's be sure to look at what there is to start with!

And keep in mind, too many labels may be overwhelming to new people -- more labels isn't /necessarily/ better!

🎉

@Manasa2850
Copy link
Member

@jywarren I have created an FTO #9535 to add more emojis to LABELS.md. Will create some more to add more emojis!

@Priyaraj17
Copy link
Contributor

@jywarren, hey this sounds a great idea. It will help a lot of first time contributers. I would really like to help in this.

@Priyaraj17
Copy link
Contributor

Some PR specific labels like tests-passing or needs-debugging if tests fail, so as to grab more attention from reviewers :)

I think it will be great for PR as I have been stuck with a PR myself. It's not passing a few tests. It will get attention or more contributers and things can be resolved soon.

@waridrox
Copy link
Member

Cool! 😄 While we are at it, it would be helpful to fix the 📢 emoji as well which currently doesn't show up on the issue template for some reason. Maybe replacing it with an actual emoji instead of the GitHub rendered one can resolve this...🤔 Thanks :)

Screenshot 2021-04-23 at 5 11 34 AM

@govindgoel
Copy link
Member

Cool! 😄 While we are at it, it would be helpful to fix the 📢 emoji as well which currently doesn't show up on the issue template for some reason. Maybe replacing it with an actual emoji instead of the GitHub rendered one can resolve this...🤔 Thanks :)

Screenshot 2021-04-23 at 5 11 34 AM

@waridrox I have opened an FTO for fixing this #9548

@unnati914
Copy link
Contributor

is there any help needed in this issue?

@unnati914
Copy link
Contributor

i can help :) in creating fto if still needed :)

@unnati914
Copy link
Contributor

adding labels like:
Level 1 : first timers
Level 2 : help wanted issues
Level 3 : advanced issues
adding these issue labels would be more understandable .. maybe?

@jywarren
Copy link
Member Author

Hi @unnati914 - I like the idea of establishing a sequence via the label descriptions. Could we write or refine the descriptions of "first-timers-only", "fto-candidate" and "help-wanted" perhaps to indicate the sequence?

@unnati914
Copy link
Contributor

ya sure.. thanks!

@7malikk
Copy link
Contributor

7malikk commented Oct 13, 2022

Hello @TildaDares , @jywarren, I'd like to make a suggestion to clean up the unused labels and add descriptions to the ones in use.
From my observation, labels like:
add-code-links is in use but has no description among others
some are not in use at all, such as hacktoberfest-accepted, meanwhile, there's already a hacktoberfest label

What are your thoughts?

@7malikk
Copy link
Contributor

7malikk commented Oct 13, 2022

Hello again, @cesswairimu Thank you for your feedback, here is one of the issues I'm interested in

@cesswairimu
Copy link
Collaborator

@7malikk thanks for your interest: some labels are seasonal like hacktoberfest-accepted which we use during hacktoberfest to mark a pull request as accepted. Maybe you could start by going through and listing the ones we haven't used at all?. And just noting since this is an edit labels one and no code change needed, you may not be able to record this as a contribution on outreachy.

@7malikk
Copy link
Contributor

7malikk commented Oct 13, 2022

@cesswairimu Thank you so much for your feedback, I'll list them out right away, I also linked you to a code-related issue I am interested here, I look forward to your feedback to that as well.

@7malikk
Copy link
Contributor

7malikk commented Oct 13, 2022

@cesswairimu @jywarren @TildaDares

Here is a list of the unused labels:

  • add-code-links
  • beginner and easy i suggest we keep one
  • fto-in-progress i believe assigned or fto-candidate perform a similar function
  • gci-candidate and reserverd-for-gci, do they fall into the seasonal labels?
  • readytomerge, ready-for-review plays the same role
  • unassigned

These are most of what i could point out, kindly point out which i can make an issue out of.
Warm regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brainstorm Issues that need discussion and requirements need to be elucidated break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration discussion fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute
Projects
None yet
Development

No branches or pull requests

10 participants