Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement card designs in embedded grids! #5960

Closed
jywarren opened this issue Jun 28, 2019 · 8 comments
Closed

Implement card designs in embedded grids! #5960

jywarren opened this issue Jun 28, 2019 · 8 comments
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute HTML UI/API improvements

Comments

@jywarren
Copy link
Member

We have these nice embedded grids that show in iframes, at urls like:

https://publiclab.org/embed/grid/questions:balloon-mapping

They look like this, on an external site like MapKnitter.org :

image

The "grid" versions don't look as good:

https://publiclab.org/embed/grid/notes:grid:balloon-mapping

Let's have the grid version (with thumbnail) use the new card designs from the style guide! cc @CleverFool77 @gautamig54 what do you think?

@jywarren
Copy link
Member Author

cc @cesswairimu this'll look cool and we can feature some balloon mapping blog posts using this, with images!

@jywarren jywarren added design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute HTML UI/API improvements labels Jun 28, 2019
@cesswairimu
Copy link
Collaborator

Awesome!!

@CleverFool77
Copy link
Member

Hi @jywarren This might be a silly question but what is embedded grid. Is it something like grid or nested grid ? 😅
regarding addition of cards, yes we can do this. Is code for this in plots2 code ?

@jywarren
Copy link
Member Author

jywarren commented Jul 8, 2019

I'm sorry to use jargon! My bad 😄

Here is some documentation about inline grids; each one can also be embedded on an external site:

https://publiclab.org/wiki/power-tags#Inline+power+tags

the thumbnail grid mode looks like this:

image

See how the table-style ones have a small "embed" button in the lower right to provide embedding codes, for embedding on other sites like YouTube videos. @cesswairimu did this on the new front page of https://MapKnitter.org!

Screen Shot 2019-07-08 at 12 50 09 PM

@Utiwari1999
Copy link

@jywarren and @SidharthBansal I want to work on this issue if it is not closed.

@jainil-4801
Copy link

@jywarren and @SidharthBansal I also want to work on this issue..

@SidharthBansal
Copy link
Member

I think you can work on this

@jywarren
Copy link
Member Author

Oh I'm sorry I've already started here! #6581

However if you can help me resolve the errors there I'd be super grateful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute HTML UI/API improvements
Projects
None yet
Development

No branches or pull requests

6 participants