Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quoted email body text ignoring _(underscore) in email #4178

Closed
SidharthBansal opened this issue Dec 7, 2018 · 6 comments
Closed

Quoted email body text ignoring _(underscore) in email #4178

SidharthBansal opened this issue Dec 7, 2018 · 6 comments
Labels
fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute

Comments

@SidharthBansal
Copy link
Member

image

See that @bansal_sidharth2996 is broken at underscore(_). We need to fix it.
@grvsachdeva
Copy link
Member

Hi @SidharthBansal, actually your name is tagged in the comment as you can see - https://publiclab.org/notes/cess/10-24-2018/outreachy-proposal#c20953 . But, yes it is not shown tagged in the quoted mail text, but I think we can ignore that. What do you think?

cc @SidharthBansal @namangupta01 @jywarren

@grvsachdeva
Copy link
Member

Feel free to close this issue, if any of you thinks, the issue doesn't need that attention. thanks!

@grvsachdeva grvsachdeva added help wanted requires help by anyone willing to contribute fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Jan 21, 2019
@SidharthBansal
Copy link
Member Author

The issue needs attention. I reported this in mailer issue.

@SidharthBansal
Copy link
Member Author

codelink must be inside config/initializer

@grvsachdeva grvsachdeva changed the title Change the regex to accept underscores Quoted email body text ignoring _(underscore) in email Jan 21, 2019
@jperk224
Copy link
Contributor

jperk224 commented Dec 7, 2020

Hi, I'm looking for a decent fto-candidate issue to work on. Is this one available for grabbing?

@willow19 willow19 mentioned this issue Apr 22, 2021
Open
7 tasks
@cesswairimu
Copy link
Collaborator

I create a username with an underscore locally and triggered a few emails tagging the name and subscriptions, It works well locally on the email template -- this may be have been fixed at some point. Closing this for now, anyone feel free to reopen if you experience the issue. Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cesswairimu @grvsachdeva @SidharthBansal @jperk224