Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the first_time_commenter function #4047

Closed
grvsachdeva opened this issue Nov 26, 2018 · 3 comments
Closed

Update the first_time_commenter function #4047

grvsachdeva opened this issue Nov 26, 2018 · 3 comments
Milestone

Comments

@grvsachdeva
Copy link
Member

In app/models/user.rb , a function by name first_time_commenter is present, which is added as a part of #3331.

Update the function such that, if a user has created any node or comment in past whose status = 1, then the user shouldn't be considered as first_time_commenter and false would be returned by function.

Make changes in function accordingly.

This issue is for Google Code-In only, other contributors please find other issues from code.publiclab.org. Thanks!

@vatbq
Copy link
Contributor

vatbq commented Dec 1, 2018

Hi! I wanna work on this but I don't find the task in GCI. Can someone give the link or some reference to search it? Thank you!

@jonxuxu
Copy link
Member

jonxuxu commented Dec 2, 2018

image

Currently, the function seems to do that already. I'm not familiar with ruby, so if I'm wrong, please let me know!

@grvsachdeva
Copy link
Member Author

Current code just checks for comment not for the node. But, anyway this task is not needed anymore, we would be using combination of first_time_poster and first_time_commenter as that makes more sense then updating this function so I have removed it from GCI dashboard.

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants