Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the button group at the bottom of infragram page #3652

Closed
Rishabh570 opened this issue Oct 9, 2018 · 13 comments
Closed

Improve the button group at the bottom of infragram page #3652

Rishabh570 opened this issue Oct 9, 2018 · 13 comments

Comments

@Rishabh570
Copy link

Please describe the problem (or idea)

The forward and fast-forward buttons in the button group at the bottom of infragram.org page are not very nice from the UI standpoint. They can be either made like the ones in publiclab.org or we can add an svg/png for them.

What happened just before the problem occurred? Or what problem could this idea solve?

Currently, the button group at infragram.org looks like,

screenshot from 2018-10-09 11-44-15

We can either make it like the one at publiclab.org, which looks like

screenshot from 2018-10-09 11-51-37

or we add an SVG/PNG, (flaticon.com has many options)

Please show us where to look

https://infragram.org

What's your PublicLab.org username?

icode365

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@faithngetich
Copy link
Contributor

I'd like to work on this issue

@champagnepappi
Copy link
Contributor

@Rishabh570 https://infragram.org seems to be an external link. is it part of the public lab plots code...

@Rishabh570
Copy link
Author

@champagnepappi Code related to infragram is here
@faithngetich Go ahead!

@faithngetich
Copy link
Contributor

Hey @Rishabh570 I have made some changes and raised a WIP PR, unfortunately, I am unable to test how it looks on the browser using my local environment. So the current changes are just based on the modification I did on the developer tools browser.
Could you please share instructions on how I can be able to view the page locally.

@Rishabh570
Copy link
Author

Hi @faithngetich, setup instructions are shown at this page itself...just run the node server and go to the related URL, you'll land on that page.

@faithngetich
Copy link
Contributor

Thanks @Rishabh570 I have been able to access the http://localhost:8000/sandbox/ but I have not been able to navigate to the local version of the site below in the screenshot. Could you please help.
screen shot 2018-10-14 at 11 48 17

@Rishabh570
Copy link
Author

@faithngetich Okay, so you want to see that button group on localhost...do this,

  • Go to index.js of routes and in export.index function, remove everything(or comment them out) such that it should contain only this:
res.render('index', {
          title: 'Infragram: online infrared image analysis',
          images: "",
          pageNumber: 1,
          pageCount: 1
        });

I think searching for an image in local db is causing the template to not get rendered...Try this and then go to localhost:8001/

@Rishabh570
Copy link
Author

@faithngetich Were you able to open that page up on localhost?

@faithngetich
Copy link
Contributor

Hey @Rishabh570 yes I have thanks.

@faithngetich
Copy link
Contributor

localhost:8001/ is not working though so I have just had to access it through localhost

@Rishabh570
Copy link
Author

No worries, you can change the port in app.js if it's not working anyways (only for development obviously)

@faithngetich
Copy link
Contributor

@Rishabh570 could you please my PR. Here's the link to the PR

@jywarren
Copy link
Member

This was solved by @faithngetich ! Thank you!

Actually if you put the exact text closes #____ where ____ is the issue number, in the PR description, then when the PR is merged, the corresponding issue is closed automatically! Just a tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants