Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the var with let #11487

Closed
5 tasks
Josephsanya opened this issue Oct 15, 2022 · 10 comments · Fixed by #11552
Closed
5 tasks

Replace the var with let #11487

Josephsanya opened this issue Oct 15, 2022 · 10 comments · Fixed by #11552
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@Josephsanya
Copy link
Contributor

Josephsanya commented Oct 15, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file inline_grids_spec.js in the publiclab/plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

-3 var editor;
+3 let editor;
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in the comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming the first-timers-only issue. We're happy to keep it assigned to you as long as you need it if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@Josephsanya Josephsanya added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Oct 15, 2022
@TildaDares
Copy link
Member

Hi @Josephsanya, thank you for opening this issue. const should be let instead.

@TildaDares TildaDares added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. and removed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Oct 15, 2022
@TildaDares
Copy link
Member

Reserved for @Divine-peace

@Josephsanya Josephsanya changed the title Replace the var with const Replace the var with let Oct 15, 2022
@Josephsanya
Copy link
Contributor Author

Okay
Thank you @TildaDares
I've corrected it

@sanmay321
Copy link

@Josephsanya hey i would like to do it, assign me please.

@Josephsanya
Copy link
Contributor Author

It has been reserved for someone else
Kindly submit your name to the list so that you'll be assigned soon

@sanmay321
Copy link

sanmay321 commented Oct 15, 2022

@Josephsanya what should I do for submitting my name to the list..?

@Josephsanya
Copy link
Contributor Author

#11105

@Josephsanya
Copy link
Contributor Author

Leave a comment there and your name will be added to the list

@Divine-peace
Copy link
Contributor

I claimed it because I would like to work on it

@onireke
Copy link

onireke commented Oct 20, 2022

Hi @TildaDares please I am yet to be assigned a FTO the only I saw was that my comment was deleted. Kindly assist me. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants