You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The findMatchedPoints function doesn't take any values explicity, those are served to it owing to the findPoints method.
Hm, why doesn't it accept two points parameters, between which it finds matches? Wouldn't that make more sense to a user? Like, it would take two points collections as inputs, and output those which are matched between? If this would take extra changes, let's do that in a follow-up PR. Can you open an issue and copy these notes in? Thanks!
The function, however, depends specifically on args.browser that's initialized all the way at the top. Do you want me to highlight this?
Yes, that doesn't seem so clear to me so it may need explaining.
So, Below is a summary of each component of the orbify instance doesn't clearly spell out that these are parameters that can be submitted in the constructor. I think it's very important to literally show verbatim how to use each of the constructors, as in this example:
That'll make it much easier for people to start using this library, or to use it in unexpected ways!
The text was updated successfully, but these errors were encountered:
rexagod
changed the title
> The findMatchedPoints function doesn't take any values explicity, those are served to it owing to the findPoints method.
Add direct linking to implicit functions
Aug 1, 2019
rexagod
changed the title
Add direct linking to implicit functions
Add direct linking to implicit functions (and expose them)
Aug 1, 2019
Hm, why doesn't it accept two
points
parameters, between which it finds matches? Wouldn't that make more sense to a user? Like, it would take two points collections as inputs, and output those which are matched between? If this would take extra changes, let's do that in a follow-up PR. Can you open an issue and copy these notes in? Thanks!Yes, that doesn't seem so clear to me so it may need explaining.
So,
Below is a summary of each component of the orbify instance
doesn't clearly spell out that these are parameters that can be submitted in the constructor. I think it's very important to literally show verbatim how to use each of the constructors, as in this example:That'll make it much easier for people to start using this library, or to use it in unexpected ways!
Thank you, @rexagod -- much appreciated!
Originally posted by @jywarren in #6
The text was updated successfully, but these errors were encountered: