From edce5256176a4fa6df7fd30c21c660229b3032d2 Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 28 Aug 2026 18:18:29 -0700 Subject: [PATCH 1/2] Reference AGENTS.md's unresolved-rule line instead of copying it (#1070) local-strict-review/SKILL.md's subagent-briefing template restated AGENTS.md's own closing line verbatim; point at it instead so it can't drift out of sync. Regenerated the two mirrored copies via build_dist.py. --- .agents/skills/local-strict-review/SKILL.md | 4 ++-- .claude-plugin/fleet-skills/.source-digest | 2 +- .../fleet-skills/skills/local-strict-review/SKILL.md | 4 ++-- .github/skills/local-strict-review/SKILL.md | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.agents/skills/local-strict-review/SKILL.md b/.agents/skills/local-strict-review/SKILL.md index 7a2eb75f..3b77e323 100644 --- a/.agents/skills/local-strict-review/SKILL.md +++ b/.agents/skills/local-strict-review/SKILL.md @@ -48,10 +48,10 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. -If a rule you were given does not cover what you find, stop and report it. Do not guess, and do - not read a governance file to resolve it. ``` +Close the brief with the same unresolved-rule line as `AGENTS.md`'s own template, quoted from there rather than restated here. + **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. ## Disposing of Findings diff --git a/.claude-plugin/fleet-skills/.source-digest b/.claude-plugin/fleet-skills/.source-digest index c7e837e4..03a54f7f 100644 --- a/.claude-plugin/fleet-skills/.source-digest +++ b/.claude-plugin/fleet-skills/.source-digest @@ -1 +1 @@ -8cab4f8afbf9a439 +cada32bba491620d diff --git a/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md b/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md index 7a2eb75f..3b77e323 100644 --- a/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md +++ b/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md @@ -48,10 +48,10 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. -If a rule you were given does not cover what you find, stop and report it. Do not guess, and do - not read a governance file to resolve it. ``` +Close the brief with the same unresolved-rule line as `AGENTS.md`'s own template, quoted from there rather than restated here. + **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. ## Disposing of Findings diff --git a/.github/skills/local-strict-review/SKILL.md b/.github/skills/local-strict-review/SKILL.md index 7a2eb75f..3b77e323 100644 --- a/.github/skills/local-strict-review/SKILL.md +++ b/.github/skills/local-strict-review/SKILL.md @@ -48,10 +48,10 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. -If a rule you were given does not cover what you find, stop and report it. Do not guess, and do - not read a governance file to resolve it. ``` +Close the brief with the same unresolved-rule line as `AGENTS.md`'s own template, quoted from there rather than restated here. + **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. ## Disposing of Findings From 102222752a48e16fbbbc03319ffe3cb824d44f2c Mon Sep 17 00:00:00 2001 From: Pieter Viljoen Date: Fri, 28 Aug 2026 19:42:55 -0700 Subject: [PATCH 2/2] Fix skill-review findings: keep closing reference inside the fence CodeRabbit caught a copy-paste completeness gap: the round-1 fix moved the unresolved-rule pointer entirely outside the fenced template, so pasting just the fence dropped it. Moved the reference back inside the fence, phrased to point at AGENTS.md rather than restate its wording. --- .agents/skills/local-strict-review/SKILL.md | 4 ++-- .claude-plugin/fleet-skills/.source-digest | 2 +- .../fleet-skills/skills/local-strict-review/SKILL.md | 4 ++-- .github/skills/local-strict-review/SKILL.md | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.agents/skills/local-strict-review/SKILL.md b/.agents/skills/local-strict-review/SKILL.md index 3b77e323..ba5dfbe6 100644 --- a/.agents/skills/local-strict-review/SKILL.md +++ b/.agents/skills/local-strict-review/SKILL.md @@ -48,10 +48,10 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. +Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation + Discipline", referenced rather than restated here. ``` -Close the brief with the same unresolved-rule line as `AGENTS.md`'s own template, quoted from there rather than restated here. - **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. ## Disposing of Findings diff --git a/.claude-plugin/fleet-skills/.source-digest b/.claude-plugin/fleet-skills/.source-digest index 03a54f7f..e1971e55 100644 --- a/.claude-plugin/fleet-skills/.source-digest +++ b/.claude-plugin/fleet-skills/.source-digest @@ -1 +1 @@ -cada32bba491620d +126057363d858c0a diff --git a/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md b/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md index 3b77e323..ba5dfbe6 100644 --- a/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md +++ b/.claude-plugin/fleet-skills/skills/local-strict-review/SKILL.md @@ -48,10 +48,10 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. +Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation + Discipline", referenced rather than restated here. ``` -Close the brief with the same unresolved-rule line as `AGENTS.md`'s own template, quoted from there rather than restated here. - **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. ## Disposing of Findings diff --git a/.github/skills/local-strict-review/SKILL.md b/.github/skills/local-strict-review/SKILL.md index 3b77e323..ba5dfbe6 100644 --- a/.github/skills/local-strict-review/SKILL.md +++ b/.github/skills/local-strict-review/SKILL.md @@ -48,10 +48,10 @@ Rules that bind this task: quote `code-review`'s "Review the Change" section int the Return line below, not a PR comment or a coverage marker. Return: one finding per line, file:line, the concrete failure scenario, no severity theater. Bounds: read-only. No edit, no stage, no commit, no push, no PR-hosted write of any kind. +Close with the unresolved-rule closing line from `AGENTS.md` "Context and Delegation + Discipline", referenced rather than restated here. ``` -Close the brief with the same unresolved-rule line as `AGENTS.md`'s own template, quoted from there rather than restated here. - **Model tier:** the strongest tier this session can reach, per `AGENTS.md` "Match the model tier to the judgment" and "Never tier down the seat holding the judgment", applied here to the reviewer rather than the author. Run the pass on the same tier that authored the change when only one tier is reachable, a second, adversarially-prompted look still catches what the authoring pass's own "looks ready" judgment did not. ## Disposing of Findings