Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed IP change still triggers a rebuild on the daemon #71

Closed
DaneEveritt opened this issue Aug 31, 2016 · 0 comments
Closed

Failed IP change still triggers a rebuild on the daemon #71

DaneEveritt opened this issue Aug 31, 2016 · 0 comments
Assignees
Labels
bug Something that's not working as it's intended to be.
Milestone

Comments

@DaneEveritt
Copy link
Member

On the Panel:

An unhandled exception occured while attemping to modify the default connection for this server.

On the Daemon:

02:35:57.541Z  INFO pterodactyl.daemon: New configiguration has changes to the server's build settings. Server has been queued for rebuild on next boot. (server=94545fd1-ae41-43c5-8842-3f5e30465691)

(also, typo there, configiguration)

In the changeBuild() function of the ServerRepository we are calling

$server->save();
DB::commit();

after we call the $client->request() method which negates the point of error handling there. We should be trying $server->save(), then calling the request, and then calling DB::commit(); once both of those succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as it's intended to be.
Projects
None yet
Development

No branches or pull requests

1 participant