Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB_TOKEN has bugs #142

Closed
peaceiris opened this issue Sep 24, 2019 · 5 comments · Fixed by #143
Closed

GITHUB_TOKEN has bugs #142

peaceiris opened this issue Sep 24, 2019 · 5 comments · Fixed by #143

Comments

@peaceiris
Copy link

peaceiris commented Sep 24, 2019

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Check https://github.com/pterodactyl/documentation/commits/gh-pages, you find that GitHub Pages build event did not start.

Please do not use GITHUB_TOKEN, use ACTIONS_DEPLOY_KEY or PERSONAL_TOKEN

cf. peaceiris/actions-gh-pages#9

@schrej
Copy link
Member

schrej commented Sep 24, 2019

I think in this case it was because I messed up the if: statement for the deploy step. After we fixed that, it started to deploy.

@peaceiris
Copy link
Author

@DaneEveritt
Copy link
Member

Yes, I'm unsure what you're saying the issue is here? It appears to have deployed without a problem?

@peaceiris
Copy link
Author

There is no checkmark. We cannot access the event log of this commit. This means that GitHub Pages build event did not start.

github

See this log: https://github.com/pterodactyl/documentation/deployments

You can find the latest event "2 days ago".

Screen Shot 2019-09-25 at 11 46 57

@peaceiris
Copy link
Author

LGTM. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants