Skip to content

Commit b9519f9

Browse files
katrecopybara-github
authored andcommitted
Make StarlarkExecGroupContext use AutoValue.
This gives reasonable equals and hashCode behavior. PiperOrigin-RevId: 367493368
1 parent 91483e8 commit b9519f9

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkExecGroupCollection.java

+4-11
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public StarlarkExecGroupContext getIndex(StarlarkSemantics semantics, Object key
8282
String.join(", ", getScrubbedExecGroups()));
8383
}
8484
ToolchainContextApi toolchainContext = toolchainCollection().getToolchainContext(execGroup);
85-
return new StarlarkExecGroupContext(toolchainContext);
85+
return new AutoValue_StarlarkExecGroupCollection_StarlarkExecGroupContext(toolchainContext);
8686
}
8787

8888
private static String castGroupName(Object key) throws EvalException {
@@ -113,17 +113,10 @@ private List<String> getScrubbedExecGroups() {
113113
* The starlark object that is returned by ctx.exec_groups[<name>]. Gives information about that
114114
* exec group.
115115
*/
116-
public static class StarlarkExecGroupContext implements ExecGroupContextApi {
117-
ToolchainContextApi toolchainContext;
118-
119-
private StarlarkExecGroupContext(ToolchainContextApi toolchainContext) {
120-
this.toolchainContext = toolchainContext;
121-
}
122-
116+
@AutoValue
117+
public abstract static class StarlarkExecGroupContext implements ExecGroupContextApi {
123118
@Override
124-
public ToolchainContextApi toolchains() {
125-
return toolchainContext;
126-
}
119+
public abstract ToolchainContextApi toolchains();
127120

128121
@Override
129122
public void repr(Printer printer) {

0 commit comments

Comments
 (0)