Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting the output directory to create_pbp_file macro #244

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add support for setting the output directory to create_pbp_file macro #244

merged 2 commits into from
Oct 31, 2024

Conversation

sharkwouter
Copy link
Member

This will allow us to make sure SDL can build with -j8 for when building tests and it is also just nice to be able to set the output directory.

diamant3
diamant3 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@diamant3 diamant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!, we can now set the output of EBOOT.PBP.

@sharkwouter sharkwouter merged commit 47eb5db into master Oct 31, 2024
2 checks passed
@sharkwouter sharkwouter deleted the set-eboot-output-directory branch October 31, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diamant3 diamant3 diamant3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkwouter @diamant3