If a process crashes half-way through writing a cache entry to a file cache, it will get corrupted

[itamarst]

For FileCache this may not be a problem insofar as deserializing will fail? For SeparateBodyFileCache it will be, insofar as it's just a pile-of-bytes for the data in the body file.

pip doesn't have this problem since it writes to a temporary file and then uses os.replace(). CacheControl may wish to adopt this.

[woodruffw]

pip doesn't have this problem since it writes to a temporary file and then uses os.replace(). CacheControl may wish to adopt this.

Makes sense. Would you be interested in sending a patch for this? Otherwise, I'll possibly have some time to look into this in the coming weeks (but no guarantees).

[itamarst]

The relevant code in pip is https://github.com/pypa/pip/blob/8a0f77c171d60344e6a3bf6e95ad5740c21575fd/src/pip/_internal/network/cache.py#L57, could probably just copy-paste the relevant utility code and integrate with the locking.