Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce build times for dependents by moving build.rs to a snapshot test #791

Open
epage opened this issue Jan 16, 2025 · 0 comments
Open

Comments

@epage
Copy link

epage commented Jan 16, 2025

Generating static code in a build.rs works well when there is a lot of churn as developers can make a change and its automatically applied. This comes at a cost to dependents who have to build and run the build script, multiplying out the build time costs across the community.

I assume the schema for sarif does not see a lot of churn and it seems like it could offer good build benefits for this repo and for dependents to move code generation to a test.

e.g. https://github.com/crate-ci/typos/blob/3683264986a72f63f13e9e8fc132a13af2a322b8/crates/typos-dict/tests/codegen.rs#L1-L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant