Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] OPL crashes when it finds games in .ul format. #496

Closed
2 tasks done
J013k opened this issue Aug 20, 2021 · 7 comments · Fixed by #517
Closed
2 tasks done

[ISSUE] OPL crashes when it finds games in .ul format. #496

J013k opened this issue Aug 20, 2021 · 7 comments · Fixed by #517
Assignees
Labels
Milestone

Comments

@J013k
Copy link
Contributor

J013k commented Aug 20, 2021

Checks

Describe the issue

OPL 1748 crashes when it finds games in .ul format.
I mean the crash happens while loading games' list.
https://i.postimg.cc/fRtgY7Kq/bbuubu-OPL.png
When there aren't any games in this format everything is fine.

This problem happens through SMB & USB.

Console model

SCPH-77004, SCPH-50004

OPL version / revision

v1.1.0-Beta-1748-c43f188

In which device(s) have you experienced this issue?

USB, SMB

Context and extra information

I have noticed that recently some changes have been done for .ul format:
Rev 1748 - USBExtreme format extended:
c43f188.

@J013k J013k added the bug label Aug 20, 2021
@AKuHAK
Copy link
Member

AKuHAK commented Aug 21, 2021

Yes, I implemented size calculation for ul games, but probably made some memory leaks in process. @KrahJohlito, I will be able to check this only next week, if you cant find where is memory leaks (probably path should be unlink() ), feel free to revert my changes

@KrahJohlito
Copy link
Member

KrahJohlito commented Aug 21, 2021

@AKuHAK size works well, https://github.com/KrahJohlito/Open-PS2-Loader/actions/runs/1153524239 should be all good here.. did a quick test @J013k can you double check please

@KrahJohlito KrahJohlito mentioned this issue Aug 21, 2021
6 tasks
@J013k
Copy link
Contributor Author

J013k commented Aug 21, 2021

This issue has been fixed in upcoming PR (499).
OPL shows Games' list for USB and SMB when there are games in .ul format.

Additionally it is also calculating and showing their size:

  • .ul
    https://i.postimg.cc/brshqrcY/size-1.png
  • ISO
    https://i.postimg.cc/x8hS8Qnv/size-2.png

@J013k J013k closed this as completed Aug 21, 2021
@AKuHAK AKuHAK reopened this Aug 21, 2021
@AKuHAK
Copy link
Member

AKuHAK commented Aug 21, 2021

can you confirm that #499 fixed the issue for you? I mean, did you actually tested it?

@J013k
Copy link
Contributor Author

J013k commented Aug 21, 2021

I have this problem with v1.1.0-Beta-1748-c43f188 but not with
OPL-v1.1.0-Beta-1759-6b0ca82.ELF from https://github.com/ps2homebrew/Open-PS2-Loader/actions/runs/1153515834.

I also additionally added some photos which are in my previous post.

I could not make a photo of a calculated ISO or .ul size in v1.1.0-Beta-1748-c43f188 because games' list is crashing almost immediately.

In OPL-v1.1.0-Beta-1759-6b0ca82.ELF games' list is showing. I can check games' size (for ISO as well as for .ul).

The only problem that I currently have has been written in upcoming PR (499).
I mean I cannot launch any game.

Best regards.

@J013k
Copy link
Contributor Author

J013k commented Aug 27, 2021

@KrahJohlito could you add your PR with fixes for this issue (496)
and when OPL creates folders on a memory card (497)?

@KrahJohlito
Copy link
Member

I’ve wanted to take a break from ps2 for the past month but things kept coming up.. now I’m forcing myself to, someone else can do it if they have time and want to or it’s possible I’ll do it another time.

Best regards.

@AKuHAK AKuHAK self-assigned this Aug 28, 2021
@rickgaiser rickgaiser added this to the v1.1.0 milestone Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants