Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save setting on MC #302

Closed
J013k opened this issue Jul 26, 2020 · 6 comments · Fixed by #308
Closed

Cannot save setting on MC #302

J013k opened this issue Jul 26, 2020 · 6 comments · Fixed by #308
Labels

Comments

@J013k
Copy link
Contributor

J013k commented Jul 26, 2020

Currently I have only tested OPL 1541, but I cannot save setting on MC, when I don't have OPL folder on MC.
No matter if I have memory card in slot 1 or in slot 2.
I'm getting: "Error writing settings!".

If I will create OPL folder, I can finally save settings.

Tested on SCPH-77004.

@J013k J013k added the bug label Jul 26, 2020
@KrahJohlito
Copy link
Member

I did some testing and it stopped being able to mkdir on MC here f84d508. @uyjulian any ideas?

@uyjulian
Copy link
Member

The OPL folder on memory card is checked here:

DIR *dir = opendir(path);

mcID is set to either 0x30 or 0x31 depending on where the folder is found:

static int checkMC()

This passed into the snprintf call as-is will result in the following:
mc48:OPL
mc49:OPL
depending on where the folder was found.
The ones bit will still be set correctly, so it may be the reason for differing behavior.

@KrahJohlito
Copy link
Member

Ok I tested further using github CI builds because where I got the builds from before was incorrect.. so its actually fine in r1534 but broken in r1535 not r1537 like I thought.. so it was actually 61d1ccb that it stopped working..

@J013k you wanna confirm this please..
r1534 - Works
r1535 - Broken
(links are the revision numbers)

@J013k
Copy link
Contributor Author

J013k commented Aug 1, 2020

I have the resutls.
Saving setting without OPL folder on MC works with r1534.
Fails to save settings on r1535.

@uyjulian
Copy link
Member

uyjulian commented Aug 1, 2020

I'll do some more tests to see what is causing the issue…

@J013k
Copy link
Contributor Author

J013k commented Aug 3, 2020

Fixed in upcoming PR #308:
#308.

@J013k J013k closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants