Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't dismiss tooltip using visible = false #9

Closed
StevenMasini opened this issue Sep 7, 2018 · 2 comments
Closed

Can't dismiss tooltip using visible = false #9

StevenMasini opened this issue Sep 7, 2018 · 2 comments

Comments

@StevenMasini
Copy link

Hi Pranav,

I found out that you can't use the props visible to dismiss the tooltips.
Actually you forgot to mention the dismiss props in your documentation. That's the one that should be used to dismiss the tooltips.

But also while dismiss must be equal to true, the visible props must also be equal to true.

componentDidUpdate() {
    if (this.props.visible && this.props.reference) {
      if (this.props.dismiss) {
        Tooltips.Dismiss(findNodeHandle(this.props.reference));
      } else {
        Tooltips.Show(findNodeHandle(this.props.reference), {
          text: this.props.text,
          position: this.props.position,
          align: this.props.align,
...

I think we should mention in the documentation, explain how to dismiss the tooltip.

@prscX
Copy link
Owner

prscX commented Sep 8, 2018

Thanks @StevenMasini for raising the issue.

I have fixed and pushed a release with the same. Can you please install/download latest version of library.

Please let me know incase you still face the same issue.

Thanks
</ Pranav >

@prscX prscX closed this as completed Sep 8, 2018
@prscX prscX mentioned this issue Sep 8, 2018
@StevenMasini
Copy link
Author

I saw the fix, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants