Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a callback function onHide ToolTip #1

Closed
congnguyen91 opened this issue Feb 26, 2018 · 4 comments
Closed

Need a callback function onHide ToolTip #1

congnguyen91 opened this issue Feb 26, 2018 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@congnguyen91
Copy link

Thank for your module! It would be better if it has a callback when tooltip hided :)

@prscX
Copy link
Owner

prscX commented Mar 2, 2018

Hi @congnguyen91,

I have added onHide callback support for both Android & iOS. On iOS their are few issue's for which I have raised the PR: 6 to native library, once it is approved onHide callback will start working on iOS as well.

Please download the latest V0.0.3 in order to use this functionality.

Thanks
Pranav

@prscX prscX self-assigned this Mar 9, 2018
@prscX prscX added the bug Something isn't working label Mar 9, 2018
@prscX
Copy link
Owner

prscX commented Mar 22, 2018

Hi @congnguyen91, I have pointed iOS native library onHide fix to my fork. Once it is merged I will point the same to original release version tag.

Now you will be able to get onHide callback on both Android and iOS. Let me know in case you face any issues.

Thanks
Pranav

@prscX prscX closed this as completed Mar 22, 2018
@bradyhigginbotham
Copy link

Is the onHide fix available in v0.0.4 for iOS? onHide does not seem to be firing in the simulator when the tooltip is closed. This is when using either autoHide or clickToHide. The tip closes; the callback just isn't fired.

<View ref={this.updateRef}>
  <Button title="Open Tooltip" onPress={this.onPress} />
  <Tooltip
    text="sample tip message"
    textSize={14}
    clickToHide
    onHide={() => console.log('hidden')} <== not firing
    visible={this.state.visible}
    reference={this.state.reference}
  />
</View>

@prscX
Copy link
Owner

prscX commented May 31, 2018

Thanks @bradyhigginbotham for raising the concern. I have tested onHide on latest version 0.0.6 and it is working as expected.

Can you please install the same and verify, please let me know in case you still face the same issue.

Thanks
</ Pranav >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants