Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope object in v1 metadata is missing party type info for owners #89

Closed
4 tasks
iramiller opened this issue Feb 22, 2021 · 0 comments · Fixed by #90
Closed
4 tasks

Scope object in v1 metadata is missing party type info for owners #89

iramiller opened this issue Feb 22, 2021 · 0 comments · Fixed by #90
Assignees
Labels
bug Something isn't working metadata Metadata Module
Milestone

Comments

@iramiller
Copy link
Member

Summary of Bug

Scope object in v1 uses repeated string owner_address = 3; but v0 used repeated contract.Recital parties = 2;. This results in loss of party type information for addresses in the owner list on the scope.

Remediation

Update the scope protobuf object for v1 to use a repeated list of Party so addresses are paired with a role in the data_owner field. Update associated validation and tests to match


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working metadata Metadata Module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants