Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock proto update check in workflow #842

Closed
4 tasks
egaxhaj opened this issue May 27, 2022 · 0 comments · Fixed by #843
Closed
4 tasks

Unblock proto update check in workflow #842

egaxhaj opened this issue May 27, 2022 · 0 comments · Fixed by #843
Assignees
@egaxhaj
Labels
dependencies Pull requests that update a dependency file proto Protobuf files work
Milestone
v1.11.0

Comments

@egaxhaj
Copy link
Contributor

egaxhaj commented May 27, 2022 •
edited
Loading

Summary of Bug

An additional check needs to occur to unblock the workflow from firing exit code 1 when checking to see if third_party proto files require updates. This check needs to verify that proto files were updated an no further changes are required resulting in the workflow passing.

This is continuation work on #838 that resulted in an auto-merge.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@egaxhaj egaxhaj added dependencies Pull requests that update a dependency file proto Protobuf files work labels May 27, 2022
@egaxhaj egaxhaj added this to the v1.11.0 milestone May 27, 2022
@egaxhaj egaxhaj self-assigned this May 27, 2022
@egaxhaj egaxhaj mentioned this issue May 27, 2022
Merged
8 tasks
Repository owner moved this from Todo to Done in Provenance Core Protocol Team Jun 10, 2022
@iramiller iramiller modified the milestones: v1.12.0, v1.11.0 Jun 13, 2022
@Taztingo Taztingo mentioned this issue Jun 16, 2022
Closed
4 tasks
@iramiller iramiller moved this from Done to Archive in Provenance Core Protocol Team Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egaxhaj egaxhaj

Labels
dependencies Pull requests that update a dependency file proto Protobuf files work
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

unblock proto update check provenance-io/provenance
2 participants
@iramiller @egaxhaj