Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update release actions to properly set "prerelease" flag on RCs #666

Closed
4 tasks
iramiller opened this issue Feb 16, 2022 · 0 comments · Fixed by #768
Closed
4 tasks

update release actions to properly set "prerelease" flag on RCs #666

iramiller opened this issue Feb 16, 2022 · 0 comments · Fixed by #768
Assignees
@dwedul-figure
Labels
CI Continuous Integration and release process github_actions Pull requests that update Github_actions code
Milestone
v.1.9.0

Comments

@iramiller
Copy link
Member

Summary of Bug

Currently the step of the github action which creates the release always sets pre-release to false. This should be true for RC type releases.

Version

n/a

Steps to Reproduce

Create a new RC type release, note that the release is not marked as a pre-release.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added CI Continuous Integration and release process github_actions Pull requests that update Github_actions code labels Feb 16, 2022
@iramiller iramiller added this to the v1.9.0 milestone Feb 16, 2022
@dwedul-figure dwedul-figure self-assigned this Apr 1, 2022
@dwedul-figure dwedul-figure mentioned this issue Apr 1, 2022
Merged
8 tasks
@dwedul-figure dwedul-figure moved this from Todo to In Progress in Provenance Core Protocol Team Apr 1, 2022
Repository owner moved this from In Progress to Done in Provenance Core Protocol Team Apr 5, 2022
@iramiller iramiller modified the milestones: v1.10.0, v.1.9.0 Apr 12, 2022
@iramiller iramiller moved this from Done to Archive in Provenance Core Protocol Team Sep 20, 2022
This was referenced Nov 15, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwedul-figure dwedul-figure

Labels
CI Continuous Integration and release process github_actions Pull requests that update Github_actions code
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v.1.9.0
Development

Successfully merging a pull request may close this issue.

Properly set the prerelease flag for release candidates. provenance-io/provenance
2 participants
@iramiller @dwedul-figure