Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Record implementation to Metadata module #54

Closed
8 of 14 tasks
iramiller opened this issue Feb 9, 2021 · 1 comment · Fixed by #110
Closed
8 of 14 tasks

Add Record implementation to Metadata module #54

iramiller opened this issue Feb 9, 2021 · 1 comment · Fixed by #110
Assignees
Labels
metadata Metadata Module
Milestone

Comments

@iramiller
Copy link
Member

iramiller commented Feb 9, 2021

Summary

Implement basic metadata structure for Records

Problem Definition

  • Review proto message for appropriate identifiers and structure, update as needed
  • Implement ValidateBasic for Record
  • Add NewRecord functions for creating an instance of Record
  • Create test suite to cover basic validation logic
  • Implement appropriate Stringer interface method, add test case
  • Create associated keeper file for Record.
    • Get/Set/Remove methods for object in state store (include events and instrumentation publishing). Ensure remove method fails if there are any existing references to object. Update any indexes that might be useful for rapidly querying/accessing data for queries. Example: all scopes with a given value_owner
    • Stateful validation of object (pull existing, verify any updates are allowed, etc). For a record this will require implementation of the RecordSpecification. Leave this work for a future issue after specifications are in place.
    • Implement iterator using KVStorePrefixIterator and appropriate prefix
  • Wire up msg_server and query_server endpoints to new keeper methods.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller
Copy link
Member Author

Stateful validation of a Record will require the RecordSpecification #58. Update the Record message in the proto to add a reference to the RecordSpecification.

@iramiller iramiller added this to the Metadata Module Release milestone Feb 10, 2021
@iramiller iramiller mentioned this issue Feb 10, 2021
8 tasks
@jdfigure jdfigure added the metadata Metadata Module label Feb 17, 2021
@jdfigure jdfigure modified the milestones: Metadata Module Release, Testnet Beta Feb 22, 2021
@channa-figure channa-figure self-assigned this Feb 22, 2021
@channa-figure channa-figure modified the milestones: 1.0.0, 0.2.0 Feb 25, 2021
@iramiller iramiller moved this from Todo to Done in Provenance Core Protocol Team Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata Metadata Module
Projects
Development

Successfully merging a pull request may close this issue.

3 participants