Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server and client configuration defaults based on testnet/mainnet #403

Closed
4 tasks
iramiller opened this issue Jul 29, 2021 · 0 comments · Fixed by #405
Closed
4 tasks

Update server and client configuration defaults based on testnet/mainnet #403

iramiller opened this issue Jul 29, 2021 · 0 comments · Fixed by #405
Assignees
Labels
CLI Command line interface feature enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@iramiller
Copy link
Member

iramiller commented Jul 29, 2021

Summary

Set configuration defaults that match current mainnet and testnet provenance networks

Problem Definition

When new nodes/validators join the Provenance networks their starting configuration is often based on what the provenanced init command sets up instead of the customized configuration used in the official testnet/mainnet repositories. This feature would update the defaults in the binary such that the initialized config would match these environments

Proposal

Add additional configuration default overrides to the provenanced init flow so that configuration matches the recommended settings in the testnet/mainnet repositories. Check the --testnet flag status to determine which environment to use as a template/reference for config values.

NOTE: For the testnet configuration do not include the seed nodes or related network settings that would conflict with setting up a development environment.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller changed the title Set default values for config file created with init to match the default from mainnet and testnet repositories based on supplied --testnet flag value Update server and client configuration defaults based on testnet/mainnet Jul 29, 2021
@iramiller iramiller added the CLI Command line interface feature label Jul 29, 2021
@iramiller iramiller added this to the v1.6.0 milestone Jul 29, 2021
@iramiller iramiller added enhancement New feature or request good first issue Good for newcomers labels Jul 29, 2021
@iramiller iramiller moved this from Todo to Done in Provenance Core Protocol Team Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Command line interface feature enhancement New feature or request good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants