Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update event documentation to reflect typed events encoding #304

Closed
4 tasks
iramiller opened this issue May 6, 2021 · 0 comments · Fixed by #338
Closed
4 tasks

Update event documentation to reflect typed events encoding #304

iramiller opened this issue May 6, 2021 · 0 comments · Fixed by #338
Assignees
@iramiller
Labels
attribute Attribute Module bug Something isn't working documentation Improvements or additions to documentation marker Marker Module metadata Metadata Module name Name Module
Milestone
v1.4.0

Comments

@iramiller
Copy link
Member

Summary of Bug

Typed events change the key/value/attribute naming of event data. The spec docs need to be updated to reflect these.

Version

1.3.0-HEAD

Steps to Reproduce

Review event output, note that names do not match docs due to missing namespaces.

provenance.metadata.v1.EventScopeCreated vs EventScopeCreated in the docs.

https://github.com/provenance-io/provenance/blob/main/x/metadata/spec/05_events.md#eventscopecreated

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added bug Something isn't working documentation Improvements or additions to documentation marker Marker Module metadata Metadata Module attribute Attribute Module name Name Module labels May 6, 2021
@iramiller iramiller added this to the v1.4.0 milestone May 6, 2021
@iramiller iramiller self-assigned this Jun 2, 2021
@iramiller iramiller mentioned this issue Jun 2, 2021
Merged
8 tasks
@iramiller iramiller moved this from Todo to Done in Provenance Core Protocol Team Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iramiller iramiller

Labels
attribute Attribute Module bug Something isn't working documentation Improvements or additions to documentation marker Marker Module metadata Metadata Module name Name Module
Projects
Provenance Core Protocol Team
Archived in project
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

Update marker event spec documentation provenance-io/provenance
1 participant
@iramiller