Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update denom regex formater in compile #258

Closed
iramiller opened this issue Apr 19, 2021 · 1 comment · Fixed by #260 or #263
Closed

Update denom regex formater in compile #258

iramiller opened this issue Apr 19, 2021 · 1 comment · Fixed by #260 or #263
Assignees
Labels
bug Something isn't working marker Marker Module
Milestone

Comments

@iramiller
Copy link
Member

Currently the unrestricted denom expression does not include the anchors but they are always required

if r, err := regexp.Compile(params.UnrestrictedDenomRegex); err != nil {

Update this to the following style from the SDK so that the regex is always properly anchored

 r, err := regexp.Compile(fmt.Sprintf(`^%s$`,params.UnrestrictedDenomRegex))
@iramiller iramiller added bug Something isn't working marker Marker Module labels Apr 19, 2021
@iramiller iramiller modified the milestones: 1.1.0, v1.2.0 Apr 19, 2021
@iramiller iramiller self-assigned this Apr 21, 2021
@iramiller iramiller reopened this Apr 23, 2021
@iramiller
Copy link
Member Author

We don't want to use the slash due to IBC... seems like adding period and dash to our unrestricted denom expression (limit 2,64 length) and to the base coin denom (2,127 length--set in app.go) are the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working marker Marker Module
Projects
1 participant