Refactor attribute validation

[channa-figure]

Description

Refactor existing Validate method in x/attribute/types/attribute.go to be ValidateBasic to follow sdk standard.

closes: #44

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[codecov]

Codecov Report

Merging #175 (664e135) into main (f489d23) will decrease coverage by 0.35%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   46.06%   45.71%   -0.36%     
==========================================
  Files          96      102       +6     
  Lines        7858     8161     +303     
==========================================
+ Hits         3620     3731     +111     
- Misses       3830     4015     +185     
- Partials      408      415       +7     

Impacted Files	Coverage Δ
x/attribute/types/genesis.go	0.00% <0.00%> (ø)
x/attribute/keeper/keeper.go	66.66% <87.50%> (ø)
x/attribute/keeper/genesis.go	23.07% <100.00%> (ø)
x/attribute/types/attribute.go	86.41% <100.00%> (+50.52%)	⬆️
x/attribute/types/msgs.go	19.56% <100.00%> (ø)
x/attribute/keeper/msg_server.go	2.27% <0.00%> (ø)
x/attribute/keeper/query_server.go	0.00% <0.00%> (ø)
x/attribute/keeper/params.go	100.00% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f489d23...664e135. Read the comment docs.

[ghost]

I guess this is fine (consistency in naming), but ValidateBasic is a sdk.Msgthing, not a general naming convention thing in Go.

[iramiller]

We need to add the stateful check on attribute length based on the current configured max value length. The validation that occurs in the types folder must be stateless thus the "validatebasic" refactor...

[iramiller]

I guess this is fine (consistency in naming), but ValidateBasic is a sdk.Msgthing, not a general naming convention thing in Go.

Agreed ... the point of this issue originally was to address that the validation done in the attribute type could no longer be performed there due to the stateful property for the attribute length ... this validation has to be done in a keeper method. I think the point got lost a bit with the ValidateBasic focus @dpederson-figure

[ghost]

It's cool. Just a nit.

[iramiller]

Nice, LGTM.