Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting a NAV attribute on metadata scopes #1749

Closed
4 tasks
iramiller opened this issue Nov 15, 2023 · 2 comments · Fixed by #1791
Closed
4 tasks

Support setting a NAV attribute on metadata scopes #1749

iramiller opened this issue Nov 15, 2023 · 2 comments · Fixed by #1791
Assignees
Labels
enhancement New feature or request high High Priority metadata Metadata Module
Milestone

Comments

@iramiller
Copy link
Member

Summary

Add the ability to set a NAV on a given scope to indicate its value for TVL

Problem Definition

With the release of 1.17 markers now have a new TVL component that allows users to set information about the prices/value of a given token. Expanding on this capability we need to add a similar value to the metadata/scopes so that it is easy to declare a given value of an asset when it is created (USD).

Proposal

Add an attribute to the scope concept (doesn't have to be directly in the scope proto) which allows a user to assign a USD NAV value similar to the one set for markers. Unlike the markers there will not be an exchange function that updates these values until perhaps at a future date the exchange system is expanded to allow trading of scopes directly (instead of requiring them to be tied to a marker).


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller iramiller added enhancement New feature or request metadata Metadata Module labels Nov 15, 2023
@iramiller iramiller added this to the v1.18.0 milestone Nov 15, 2023
@nullpointer0x00
Copy link
Contributor

Are the scope NAVs only supposed to be in USD? Marker module supports multiple NAVs of different denoms. If we want to do that here, I would suggest not having a proto directly on the scope.

@iramiller
Copy link
Member Author

iramiller commented Nov 15, 2023

To start with I don't know that we will need the alternate pricing ... but that is certainly coming, if not in the first revision then in a subsequent one. It probably makes sense to keep the api consistent between the two modules though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high High Priority metadata Metadata Module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants