You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our repo has a custom fork of ibc-go, and it allowed us to access the SendTransfer method of the ibc-go Keeper. We should be able to replace this with a MsgTransfer and remove our dependency on a custom ibc-go fork.
Our custom implementation checks the following on an ibc transfer and skips the IsSendEnabledCoins check.
Our go.mod contains a reference to our ibc-go repo, and we no longer need it.
Proposal
Update go.mod to point to ibc-go v6.1.1
Pass in and store a baseapp.IMsgServiceRouter to the Marker Keeper
Update the marker keeper's IbcTransfer method to send a MsgTransfer and use the IMsgServiceRouter
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
Summary
Our repo has a custom fork of ibc-go, and it allowed us to access the SendTransfer method of the ibc-go Keeper. We should be able to replace this with a MsgTransfer and remove our dependency on a custom ibc-go fork.
Our custom implementation checks the following on an ibc transfer and skips the IsSendEnabledCoins check.
Original:
https://github.com/cosmos/ibc-go/blob/fa3116f0bd885b0ef4d7e974cb2918f9b7e4ff87/modules/apps/transfer/keeper/msg_server.go#L18-L33
Ours:
provenance/x/marker/keeper/msg_server.go
Lines 489 to 495 in de83db6
This check should not be an issue anymore because we have the Bypass Context:
https://github.com/provenance-io/provenance/blob/de83db67fbda994a6c63998d4496a95c45a01bcd/x/marker/keeper/marker.go#L709C3-L709C24
Problem Definition
Our go.mod contains a reference to our ibc-go repo, and we no longer need it.
Proposal
Update go.mod to point to ibc-go v6.1.1
Pass in and store a baseapp.IMsgServiceRouter to the Marker Keeper
Update the marker keeper's IbcTransfer method to send a MsgTransfer and use the IMsgServiceRouter
For Admin Use
The text was updated successfully, but these errors were encountered: