Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller metadata query results #1443

Closed
4 tasks
Tracked by #1440
SpicyLemon opened this issue Mar 24, 2023 · 0 comments · Fixed by #1614
Closed
4 tasks
Tracked by #1440

Smaller metadata query results #1443

SpicyLemon opened this issue Mar 24, 2023 · 0 comments · Fixed by #1614
Assignees
Labels
metadata Metadata Module wasm
Milestone

Comments

@SpicyLemon
Copy link
Contributor

SpicyLemon commented Mar 24, 2023

Summary

Make the x/metadata queries only return the entry/entries requested, without extra info.

Problem Definition

Currently, the metadata queries put each result in a wrapper that also has address info. Those address info chunks add quite a bit of data to the results. That extra data becomes problematic with smart contracts. Including the request in the response is similarly problematic.

Proposal

  1. Only optionally include the request in the responses and default to not including them.
  2. Only optionally include the id info in the responses and default to not including them. When not including id info, the entries will still be in a wrapper, but the id info fields will be nil. Handling of not-found entries should remain the same (i.e. add a wrapper entry with id info of the thing not found).
  3. Create a new GetByAddr endpoint that takes in one or more metadata addresses and returns all that are requested. This should NOT be able to include the request or id info, just the data requested. The response will need to have a list of each of the 6 metadata types as well as a list of "not found" addresses. Either the entry goes in it's appropriate list or else the address is added to "not found."

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@SpicyLemon SpicyLemon added metadata Metadata Module wasm labels Mar 24, 2023
@SpicyLemon SpicyLemon added this to the v1.15.0 milestone Mar 24, 2023
@SpicyLemon SpicyLemon mentioned this issue Mar 24, 2023
11 tasks
@iramiller iramiller moved this from Todo to Backlog in Provenance Core Protocol Team Apr 10, 2023
@iramiller iramiller modified the milestones: v1.15.0, v1.16.0 Apr 12, 2023
@SpicyLemon SpicyLemon moved this from Backlog to Todo in Provenance Core Protocol Team Apr 18, 2023
@iramiller iramiller moved this from Todo to Backlog in Provenance Core Protocol Team May 12, 2023
@iramiller iramiller modified the milestones: v1.16.0, v1.17.0 Jun 2, 2023
@iramiller iramiller moved this from Backlog to Todo in Provenance Core Protocol Team Jun 2, 2023
@SpicyLemon SpicyLemon self-assigned this Jun 30, 2023
@SpicyLemon SpicyLemon moved this from Todo to In Progress in Provenance Core Protocol Team Jun 30, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Provenance Core Protocol Team Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata Metadata Module wasm
Projects
Development

Successfully merging a pull request may close this issue.

2 participants