Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm storage via new gov proposal functionality not supported #1414

Closed
4 tasks
hyperschwartz opened this issue Mar 13, 2023 · 1 comment · Fixed by #1461
Closed
4 tasks

Wasm storage via new gov proposal functionality not supported #1414

hyperschwartz opened this issue Mar 13, 2023 · 1 comment · Fixed by #1461
Assignees
Labels
bug Something isn't working wasm
Milestone

Comments

@hyperschwartz
Copy link

Summary of Bug

When using the new gov proposal format with the v1 MsgSubmitProposal, the Wasmd msg handler uses the standard msg handling for the proposed messages. This causes all configurations to be regarded, including the config that can prevent wasm storage altogether. The way to fix this is to check if the sender of the StoreCode msg is the gov module account; if so, the configurations should not be regarded and the msg should be executed.

Version

Latest

Steps to Reproduce

  1. Disable wasm storage by setting the wasm param code_upload_access.permission to Nobody.
  2. Create a governance proposal to store code.
  3. Let proposal pass.
  4. Proposal will fail due to no permissions.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@iramiller
Copy link
Member

Seel also #1428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wasm
Projects
Development

Successfully merging a pull request may close this issue.

3 participants