Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bips field to MsgAssessCustomMsgFeeRequest and use it in provenance #1268

Closed
4 tasks
arnabmitra opened this issue Dec 15, 2022 · 0 comments · Fixed by #1285
Closed
4 tasks

Add bips field to MsgAssessCustomMsgFeeRequest and use it in provenance #1268

arnabmitra opened this issue Dec 15, 2022 · 0 comments · Fixed by #1285
Assignees
Labels
msgfees Msg based fee module
Milestone

Comments

@arnabmitra
Copy link
Contributor

Summary

Based on this #1263 it may still be good to provide a way to distribute fees between recipient and module on a more dynamic basis

Problem Definition

Based on this #1263
we should probably let the executor of the fee accessor have the ability to distribute any additional fee to the ecosystem
i.e add a string bips = 5; // bips the recipient gets field to MsgAssessCustomMsgFeeRequest

// MsgAssessCustomMsgFeeRequest defines an sdk.Msg type
message MsgAssessCustomMsgFeeRequest {
  option (gogoproto.equal)            = false;
  option (gogoproto.goproto_getters)  = false;
  option (gogoproto.goproto_stringer) = true;

  string name = 1; // optional short name for custom msg fee, this will be emitted as a property of the event
  cosmos.base.v1beta1.Coin amount = 2 [(gogoproto.nullable) = false]; // amount of additional fee that must be paid
  string recipient = 3; // optional recipient address, the total amount is given to the recipient, if present.
  string from      = 4; // the signer of the msg
  string bips      = 5; // bips the recipient gets

}

that maybe a better option

Proposal

Change proto as defined ^^.
Change code to read that field.
Change provwasm and other clients that consume it.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msgfees Msg based fee module
Projects
Development

Successfully merging a pull request may close this issue.

2 participants